ryanra/RustOS

git submodule init fails for "barn"

Closed this issue · 3 comments

I tried looking for barn on cargo, google, etc. .gitmodules just points to "file://barn" Am I missing something obvious here?

Hey, the .gitmodules were broken. I just made a commit to fix and tested that the build works with rustc version 1.14.0-nightly (a7bfb1aba 2016-10-09). Does it work for you now?

Getting closer! But getting a very odd error (repros on a clean clone) where cargo can't find a commit that is definitely there ....

RUSTFLAGS="--sysroot=/home/john/RustOS -L ." cargo build --target i686-unknown-rustos-gnu --verbose
    Updating git repository `https://github.com/alexcrichton/rlibc`
    Updating git repository `https://github.com/nathan7/libfringe`
error: failed to load source for a dependency on `fringe`

Caused by:
  Unable to update https://github.com/nathan7/libfringe?rev=45ae3505c95f607f3d9e2618a4e619c87df13b29

Caused by:
  [4/-3] Revspec '45ae3505c95f607f3d9e2618a4e619c87df13b29' not found.

Rustup:

active toolchain
----------------

nightly-2016-10-09-x86_64-unknown-linux-gnu (directory override for '/home/john/RustOS')

I even tried pointing directly to the new location of libfringe:

~/RustOS$ git diff
diff --git a/.gitmodules b/.gitmodules
index 8172eb0..64e4930 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -12,7 +12,7 @@
        url = https://github.com/ryanra/lazy-static.rs.git
 [submodule "lib/libfringe"]
        path = lib/libfringe
-       url = https://github.com/nathan7/libfringe.git
+       url = https://github.com/edef1c/libfringe.git
 [submodule "lib/barn"]
        path = lib/barn
        url = https://github.com/ryanra/barn.git
diff --git a/Cargo.toml b/Cargo.toml
index 8d617be..a41ec0c 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -19,7 +19,7 @@ git = "https://github.com/alexcrichton/rlibc"
 rev = "defb486e765846417a8e73329e8c5196f1dca49a"
 
 [dependencies.fringe]
-git = "https://github.com/nathan7/libfringe"
+git = "https://github.com/edef1c/libfringe.git"
 rev = "45ae3505c95f607f3d9e2618a4e619c87df13b29"

but still no luck.

Doesn't really seem to be specific to this project

Moving fringe to HEAD 87452b58e0a4cbef4973e81419d719b0b8fc298b seems to get things working