ryanrosello-og/playwright-slack-report

Missing init for slackOAuthToken in SlackReporter.ts

hananmalka opened this issue · 7 comments

hananmalka commented

Missing:
this.slackOAuthToken = slackReporterConfig.slackOAuthToken;

This cause the error:
Neither slackOAuthToken nor process.env.SLACK_BOT_USER_OAUTH_TOKEN were found

ryanrosello-og commented

@hananmalka can you let me know if you it works when using an environment variable SLACK_BOT_USER_OAUTH_TOKEN as opposed to setting a key in the config?

hananmalka commented

@ryanrosello-og
When using the env variable SLACK_BOT_USER_OAUTH_TOKEN it does works but I prefer to set it in the config file

ryanrosello-og commented

attempt to fix here #28
@hananmalka try v1.1.1

hananmalka commented

@ryanrosello-og tried v1.1.1 - Still getting the error.

The change you made doesn't reflect onSlackReporter.js file under dist/src

hananmalka commented

@ryanrosello-og Any update with this one?

ryanrosello-og commented

@hananmalka try v1.1.2
Seems something got messed up publishing the npm package.

hananmalka commented

@ryanrosello-og
Thanks. It works now with v 1.1.2