ryanve/eol

Doesn't work with one particular file

adam-lynch opened this issue · 4 comments

adam-lynch commented

See https://travis-ci.org/adam-lynch/gulp-image-data-uri/jobs/39278258. I'm not sure why this is. You can see that the previous build passed which is the exact same except that one particular file (double_gulp) was excluded from the tests.

Could it be that the file is very long?

adam-lynch commented

I've been debugging. I was thinking for a second that it might be chai's fault so I changed it to not compare strings but I'd compare the strings myself and then check if the result is true. Still fails :/. See https://travis-ci.org/adam-lynch/gulp-image-data-uri/jobs/39289765.

Any tips on how to debug this?

This is not a problem for me locally on Windows, just with Travis.

ryanve commented

I'm not sure. Did your Buffer commit fix it? adam-lynch/gulp-image-data-uri@d02383e

adam-lynch commented

Meant to come back and close this. It did and I have no idea why. The change to use Buffers speeded things up a lot and fixed the tests but the comparison is still expect(BufferA.toString()).to.equal(BufferB.toString()).

ryanve commented

Cool—glad you found a fix.