Shouldn't ask for score if score is already given when completing an anime
Closed this issue · 6 comments
As you can see there, I already gave score to it, it shouldn't ask for scoring. It should be ended with "Series completed with score 8.". Also, pressing enter there without typing anything throws an error. Instead of "0 for no score", it should be "Leave it empty for no score" something. I don't know if it's intended, though.
Hmmm... indeed this question is asked always when a series has been finished. I should look into this further and figure out what we can do to create a better UX.
This should change, anyway, at least let the user remains using the old score if it wish.
Thanks for the feedback!
Maybe it could still prompt the user but default to the score the user has previously entered.
For example, if I finished Shippūden with a score of 9, the message would be "Please enter a score, or hit enter to leave at 9", etc.
If the user has not yet given the anime a score, it could default to zero, and the message could read "Please enter a score, or hit enter for 0"
In case the user had already given a score prior but wanted to leave it with no score after completion, how should we got about that? Maybe we could do like @evanjs proposed and have it so a blank response keeps the current score and a hyphen would make so no score exists.
@mparadinha the idea of @evanjs is good. We could do that. But about the hyphen this is not necessary because 0 not means the score 0, because is not possible give 0 on MAL. 0 means "non-scored" which has the functionallity of your suggestion about the hyphen stuff.
We still should ask always for the user about the score because is something I wanted on the first version and I still want. In some way is pretty common to me finish a series and given a score. I'm a linear person, sometimes.
But we should do two things on this thread as we discussed:
- Change the status messages if the anime is already scored like the @kutsan suggested
- Empty answer means "keep the old score untouched" (if nothing is scored yet, would remains the same)
This is pretty straightforward to implement. Are you ok with that, @kutsan?
@kutsan since we (actually @mparadinha) already implemented this feature on #76, I'm closing this issue.
This feature will be released on MAL v0.4, you can wait until that (I don't know yet when I will release although a due date is scheduled to tomorrow on github milestone).
If you already want get this feature you can easily do that by:
pip install git+https://www.github.com/ryukinix/mal