Dependency on isFALSE

Question

Dependency on isFALSE

luke-a opened this issue 5 years ago · 8 comments

Hi there,

package installation currently seems to depend on R v3.5 because somewhere isFLASE is used, which has been introduced with 3.5. Can you remove the dependency, as discussed e.g. here, too?

Answer 1 · 2020-01-25T13:00:51.000Z

Yes I can remove that dependency; however, it will take me a while to get the next lgr version ready for CRAN. If you have lgr as a dependency for a package and it is urgent, I can consider pushing a hotfix though.

Answer 2 · 2020-01-25T13:05:30.000Z

Thanks @s-fleck , and no urgency. Just wanted to make a note, because my package installation for the latest version failed.
Have a nice weekend.

Answer 3 · 2020-01-25T13:06:48.000Z

Ok thx :)

The isFALSE() dependency is just in basic_config(), which is an optional helper for simplifying logger configuration, so it's not a very critical part of the lgr package.

Answer 4 · 2020-02-28T21:09:45.000Z

Or use https://github.com/r-lib/backports to keep it, but maybe not worth for such a function only...

Answer 5 · 2020-03-09T12:24:39.000Z

A hotfix release would be great, we are running into problems on our CI because of the missing isFALSE().

Answer 6 · 2020-03-09T14:53:00.000Z

Also note that you cannot install or load lgr for R < 3.5, basic_config() is called in .onLoad().

Answer 7 · 2020-03-14T01:46:39.000Z

yes sorry this bug was quite a (backwards compat) mess.

im currently on vecation abroad but I'll do the Cran hotfix as soon as I return home (should be in a week if the borders stay own)

Answer 8 · 2020-03-20T12:17:30.000Z

The hotfix is on its way to CRAN (so might take a few days before it becomes available). I hope everything works now. Please comment once you tested it.