tourr version dependence

Question

tourr version dependence

uschiLaa opened this issue 4 years ago · 7 comments

uschiLaa commented 4 years ago

The interface with tourr will need to be updated to work with version 0.5.7 (not yet on CRAN)

Answer 1 · 2020-09-30T02:38:07.000Z

How do you mean? As in the package doesn't work on the dev version of the tourr?

Answer 2 · 2020-09-30T02:43:14.000Z

I initially had the dev version of tourr installed, this gave me an error (which might be a bug in tourr):

limn_tour(pdfsense, PC1:PC6, Type)
Error in path(0) : object 'verbose' not found

after installing the stable tourr version from CRAN everything works ok

Answer 3 · 2020-09-30T02:45:23.000Z

Has something changed internally for new_tour() in 0.5.7?

Answer 4 · 2020-09-30T02:48:35.000Z

This is a bug in new_tour() in 0.5.7
https://github.com/ggobi/tourr/blob/26838bad2b4cd91f9b01f3ac5dff4c63acc3466c/R/tour.r#L54
It expects a boolean called verbose that isn't. passed in by default.

Want me to PR?

Answer 5 · 2020-09-30T02:50:49.000Z

Yes, there is a new "verbose" argument that turns on keeping track of information as the tour is running. It is initialised in "animate" or "save_history" as a global object, so if you call new_tour directly it is not defined. Would be good to check with Sherry, so PR or issue in the tourr repo

Answer 6 · 2020-09-30T03:05:04.000Z

Ok I'll add that in now. I'm kind of concerned about the amount of <<- with the new verbose arg. Lots of modifying the external environment which seems unnecessary.

Answer 7 · 2020-10-01T03:41:51.000Z

Ok this should work with current tour now