sachsmc/plotROC

association between higher 'm' and positive cases

Closed this issue · 1 comments

In my situation, where I am working with p values (range between 0 and 1, closer to zero enriches for positive cases, closer to one enriched for negative cases), I've had a bit of trouble.

It seems that by default, plotROC associates higher values of the 'm' variable with positive cases. So, I mapped (1 - p) to m and (1 - d) to d. But then adding cutoffs gets wonky.

Probably the cleanest solution from the user perspective is to have a binary input for which pole of 'm' is associated with positive cases and which pole is for negative cases. Should default to 'positive', but user can override.

I've fixed this in my local version by allowing custom labels for cutoffs, but that feels like a bit of a band-aid.

What are your thoughts? I feel it's possible (even likely?) I may be missing some simple solution to this issue.

I think an "increasing" argument with default value TRUE makes sense. I will work on that. The custom labels thing is complementary so let's keep that also.