saezlab/liana-py

Clarify LIANA + MOFA vignette

dbdimitrov opened this issue · 2 comments

dbdimitrov commented
  • pass sample_key explicitly
  • be explicit about resource_name
  • samples_per_view - somehow make this more obvious?
decusInLabore commented

Perhaps automatically reduce the 'samples_per_view' default parameter if mandated by the dataset structure. Alternatively, add a comment in the vignette.

  • 👍1
decusInLabore commented

In the vignette, review the mentions fo the li.mt.rank_aggregate.by_sample function add/mention the resource_name = "mouseconsensus" parameter explicitly to cater for mouse studies.

  • 👍1