safe-global/safe-react-apps

Inconsistencies with custom apps on the apps list

Closed this issue · 1 comments

Description

As we know, custom apps are now also visible under the all apps listing. This can prove to be a little inconsistent as the behaviour for these apps becomes the same one as for the apps added on the config service when it shouldn't be the case.

At this moment it is possible to bookmark custom apps from the general view (& when searching for one as reported here) but nothing will happen (which is the expected behaviour for custom apps but having them on this list makes them inherit this behaviour that they should not have)

Steps to reproduce

  1. Add a custom app
  2. Go to the 'All apps' list, find the custom app and pin it

Obtained result

App is possible to pin but it won't be pinned (same when doing this on the search view)

pinned.apps.mp4

Expected result

Two options:

  1. Keep custom apps on the 'all apps' list but remove the pin option from them.
  2. Remove custom apps from the 'all apps' list which will make them unpinable (legacy web behaviour).

Closing this ticket as discussed on the daily. We will tackle this behaviour on the main screen redesign