sagarchoudhary96/30-Days-Of-Code

Update Python Code Snippets to be compatible with python3

Closed this issue ยท 34 comments

The python solutions in the repository are written for python2.7. Would be great if they can be updated so it can be compatible with python3. Below are the list of solution already updated or confirmed that they are working with python3. You can register for Hacktoberfest here to receive free swags once you raise 4 PR.

  • Day 0 Completed
  • Day 1 Completed
  • Day 2 Completed
  • Day 3 Completed
  • Day 4 Completed
  • Day 5 Completed
  • Day 6 Completed
  • Day 7 Completed
  • Day 8 Completed
  • Day 9 Completed
  • Day 10 Completed
  • Day 11 Completed
  • Day 12 Completed
  • Day 13 Completed
  • Day 14 Completed
  • Day 15 Completed
  • Day 16 Completed
  • Day 17 Completed
  • Day 18 Completed
  • Day 19 Completed
  • Day 20 Completed
  • Day 21 Can't be completed in Python language
  • Day 22 Completed
  • Day 23 Completed
  • Day 24 Completed
  • Day 25 Completed
  • Day 26 Completed
  • Day 27 Completed
  • Day 28 Completed
  • Day 29 Completed

@sagarchoudhary96 I would like to work on it.

I am interested and would like to work on it.

hey! I have made changes to the python file of day 3 and created a pull request. Please have a look!

I would like to work on it!

@rohit1636 @sudhir512kj @sargamm @RahulRavishankar , you all are more welcomed to contribute, i will be adding contributing guidelines to the repo you can go through it to start working.

If you are making a change to an existing solution, make sure to not to change logic/syntax of what already works with python 3 and function definitions. Only minimum required changes should be done.

osoba commented

May I work on days 20, 26, 27 and 28?

I could work on "Day 1" if no one objects

osoba commented

Also notice that Day24 is already compatible with Python 3

@osoba @alexandersperling , go ahead I have assigned them to you. @osoba Thanks for letting me know i'll test it out and mark as completed/

@ironsigma , i see your pull request for 4 questions. please make sure to first post it here before picking them up. once assigned to you then only make PR. there are other people also working on these so it might clash with someone else if anyone picked the issue.

Hi! I am interested. Please assign me a file to work on.

@Priysha-Aggarwal which question you want to work on?

@sagarchoudhary96 I am currently working on days-9,10,11.

I'll take a couple of them. 4, 8, 13, 16, 19.

sure @cjtaylor1990 you can pick max 4 at one time. I will assign 4,8,13 and 16 to you.

@sagarchoudhary96 Sorry about that. I'll get on those 4 soon. =)

Hello i am interested to work on Day 29. Can i proceed?

I have completed Day 29 and raised a pull request

Cool , will check it out soon

@Kausam you can pick other one.

Day 17 is python 3 compatible

hey! I have made changes to the python file of day 14, 15, 22, 25 and created a pull request. Please have a look!

@narain1 willl assign these to you.

@osoba @cjtaylor1990 @narain1 @Priysha-Aggarwal @alexandersperling @rohit1636 there are 4 of the question left, would be great if anyone would like to pick one/two of them. Let's get this one finished soon :)

@sagarchoudhary96 I could take the 4 if you'd like. Though, it doesn't look like there are any Python solutions for 19, 21, and 23 in the repository, so I presume you'd just like me to write a solution rather than a translation. Either way, I'm up for that.

@cjtaylor1990 sure go ahead you can take all 4. The solution are not there for them. so you can add your solution. make sure to test your solution on hackerrank to make it pass all testcases.

@cjtaylor1990 any updates? you can raise PR separately too for each of them as you go on solving.

I could help if help is required

@narain1 let him respond as he has already taken up the task and must be working on them.

@sagarchoudhary96 I'm done with 18 and 19. Questions 21 and 23 are currently locked to me on HR given that I'm in the midst of doing 30 Days of Code. 21 will open tomorrow and 23 will be Friday. If you want me to submit a PR with just the two, that's fine. I just want to be able to test the solutions like you've requested, hence the delay.

@sagarchoudhary96 Day 21 doesn't support Python on Hacker Rank, so I suppose that can be crossed off.

@sagarchoudhary96 Day 23 is done. Due to the nature of the question, HackerRank doesn't support Python (2 or 3) for Day 21.

@cjtaylor1990 @narain1 @leslie-alldridge @rohit1636 @osoba @sargamm @alexandersperling and all others if i missed someone. Thanks for contributing to this issue. Looking forward to seeing more contributions in future.๐Ÿ˜Š