Change parsing of nodoctest

Question

Change parsing of nodoctest

roed314 opened this issue 13 years ago · 8 comments

Currently Sage will refrain from doctesting a file if the string "nodoctest" is in the first 50 characters. 50 characters is pretty short, and I think it's also good to encourage people to start the line with nodoctest. So I would propose that we change "somewhere in the first 50 characters" to "one of the first 10 lines starts with '# nodocteset' or '.. nodoctest'".

Depends on #12415
Depends on #14331

Component: doctest framework

Author: David Roe, Jeroen Demeyer

Reviewer: Jeroen Demeyer, David Roe

Merged: sage-5.9.beta2

Issue created by migration from https://trac.sagemath.org/ticket/13062

Answer 1 · 2013-03-14T22:25:01.000Z

comment:1

Attachment: 13062.patch.gz

Answer 2 · 2013-03-22T10:08:10.000Z

comment:2

I feel like this solution is overkill. Why not simply replace read(50) by read(512)? That should be enough and would probably be more effecient too.

Answer 3 · 2013-03-27T19:55:00.000Z

Changed dependencies from #12415 to #12415, #14331

Answer 4 · 2013-03-27T20:00:32.000Z

Attachment: 13062_nodoctest_review.patch.gz

Answer 5 · 2013-03-27T20:28:51.000Z

Author: David Roe, Jeroen Demeyer

Answer 6 · 2013-03-27T20:28:51.000Z

Reviewer: Jeroen Demeyer, David Roe

Answer 7 · 2013-03-27T20:35:44.000Z

comment:5

Looks fine to me.

Answer 8 · 2013-03-28T17:55:50.000Z

Merged: sage-5.9.beta2