sagemath/sage

Doctest debugger doesn't work on OS X

roed314 opened this issue · 11 comments

roed314 commented

sage -t --debug, a new doctesting feature introduced by #12415, doesn't work for me on OS X 10.6.8 (it starts the tests but then just hangs). Strangely, the tests in sage.doctest.forker.SageDocTestRunner.report_unexpected_exception seem to succeed.

Can anyone else duplicate this problem on another platform?

Depends on #12415

Component: doctest framework

Author: Jeroen Demeyer

Reviewer: David Roe

Merged: sage-5.9.beta1

Issue created by migration from https://trac.sagemath.org/ticket/14289

roed314 commented

Description changed:

--- 
+++ 
@@ -1 +1 @@
-`sage -t --debug`, a new doctesting feature introduced by #12415, doesn't work for me on OS X 10.6.8 (it starts the tests but then just hangs). Strangely, the tests in `sage.doctest.forker.SageDocTestRunner.report_unexpected_exception` seem to succeed. I haven't tried running tests in debug mode since Jeroen changed the backend in [attachment: attachment.12415_review.patch:ticket:12415](https://github.com/sagemath/sage/files/ticket14289/476a581e37434662505cca49d76c28ec.gz); can anyone else duplicate this problem on another platform? 
+`sage -t --debug`, a new doctesting feature introduced by #12415, doesn't work for me on OS X 10.6.8 (it starts the tests but then just hangs). Strangely, the tests in `sage.doctest.forker.SageDocTestRunner.report_unexpected_exception` seem to succeed. I haven't tried running tests in debug mode since Jeroen changed the backend in [attachment: 12415_review.patch:ticket:12415](https://github.com/sagemath/sage/files/ticket14289/ea40fca98bb90165751e68085aa0cfd1.gz); can anyone else duplicate this problem on another platform?
jdemeyer commented
comment:2

Did you check that it is really attachment: 12415_review.patch:ticket:12415 which breaks this and not one of the subsequent patches in #12415?

jdemeyer commented

Description changed:

--- 
+++ 
@@ -1 +1,3 @@
-`sage -t --debug`, a new doctesting feature introduced by #12415, doesn't work for me on OS X 10.6.8 (it starts the tests but then just hangs). Strangely, the tests in `sage.doctest.forker.SageDocTestRunner.report_unexpected_exception` seem to succeed. I haven't tried running tests in debug mode since Jeroen changed the backend in [attachment: 12415_review.patch:ticket:12415](https://github.com/sagemath/sage/files/ticket14289/ea40fca98bb90165751e68085aa0cfd1.gz); can anyone else duplicate this problem on another platform? 
+`sage -t --debug`, a new doctesting feature introduced by #12415, doesn't work for me on OS X 10.6.8 (it starts the tests but then just hangs). Strangely, the tests in `sage.doctest.forker.SageDocTestRunner.report_unexpected_exception` seem to succeed.
+
+Can anyone else duplicate this problem on another platform?
jdemeyer commented
comment:3

Adding back

import readline

in init_sage() seems to solve the problem.

jdemeyer commented

Author: Jeroen Demeyer

roed314 commented
comment:5

Thanks for figuring out what was causing this. The only change I would suggest is using

:trac:`14249`

rather than

https://github.com/sagemath/sage-prod/issues/14289
roed314 commented

Reviewer: David Roe

jdemeyer commented
comment:7

I think that

:trac:`14249`

should be used in and only in docstrings.

So I propose to leave the comment (unless you prefer Trac #14289 to the full URL).

roed314 commented
comment:8

Yes, you're right. Then it looks fine to me.

jdemeyer commented

Merged: sage-5.9.beta1