Cython dependency checking broken
jdemeyer opened this issue · 9 comments
Install the PARI spkg from #14539:
./sage -i http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.4.p0.spkg
Then rebuild the library:
./sage -b
Before #13031, this used to rebuild all files depending on PARI (good!), with #13031 absolutely nothing happens (bad!).
spkg: http://sage.math.washington.edu/home/robertwb/patches/cython-0.19.p1.spkg
apply attachment: 14544-cythonize-deps.patch to the Sage library
CC: @robertwb
Component: cython
Author: Robert Bradshaw
Reviewer: Jeroen Demeyer
Merged: sage-5.10.beta2
Issue created by migration from https://trac.sagemath.org/ticket/14544
Attachment: 14544-cythonize-deps.patch.gz
This requires a fix to the Sage library as well as cython/cython@5574592
New spkg up at http://sage.math.washington.edu/home/robertwb/patches/cython-0.19.p1.spkg
Author: Robert Bradshaw
Description changed:
---
+++
@@ -9,3 +9,7 @@
./sage -b
```
Before #13031, this used to rebuild all files depending on PARI (good!), with #13031 absolutely nothing happens (bad!).
+
+**spkg**: [http://sage.math.washington.edu/home/robertwb/patches/cython-0.19.p1.spkg](http://sage.math.washington.edu/home/robertwb/patches/cython-0.19.p1.spkg)
+
+**apply** [attachment: 14544-cythonize-deps.patch](https://github.com/sagemath/sage-prod/files/10657747/14544-cythonize-deps.patch.gz) to the Sage libraryMerged: sage-5.10.beta2
Reviewer: Jeroen Demeyer
Looks good to me.
It's not that closed in fact : what does deps.patch do? It isn't documented in SPKG.txt, and the log message only says who wrote it but not why. And since it is an upstream modification, was it forwarded?