Upgrade to Cython 0.25.1

Question

Upgrade to Cython 0.25.1

Closed this issue 9 years ago · 51 comments

Tarball: https://pypi.python.org/packages/2f/ae/0bb6ca970b949d97ca622641532d4a26395322172adaf645149ebef664eb/Cython-0.25.1.tar.gz

Depends on #21697
Depends on #21600

CC: @robertwb

Component: cython

Author: Jeroen Demeyer

Branch/Commit: 922fa16

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/20596

Answer 1 · 2016-05-12T09:42:39.000Z

Branch: u/jdemeyer/ticket/20596

Answer 2 · 2016-05-12T09:43:35.000Z

Description changed:

--- 
+++ 
@@ -1 +1,3 @@
 A workaround for http://trac.cython.org/ticket/879 is compiling as C++.
+
+This isn't actually needed right now, but it's needed to experiment with Cython git master or if Cython releases a new version without fixing that bug.

Answer 3 · 2016-05-12T09:43:35.000Z

New commits:

`60788fd`	`Work around Cython bug #879`

Answer 4 · 2016-05-12T09:43:35.000Z

Commit: 60788fd

Answer 5 · 2016-05-31T10:06:21.000Z

Changed commit from 60788fd to 51c0bcb

Answer 6 · 2016-05-31T10:06:21.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`51c0bcb`	`Work around Cython bug #879`

Answer 7 · 2016-06-08T12:54:27.000Z

Changed commit from 51c0bcb to 766dfb0

Answer 8 · 2016-06-08T12:54:27.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`766dfb0`	`Work around Cython bug #879`

Answer 9 · 2016-08-17T12:07:51.000Z

Description changed:

--- 
+++ 
@@ -1,3 +1,3 @@
-A workaround for http://trac.cython.org/ticket/879 is compiling as C++.
+A workaround for https://github.com/cython/cython/issues/1433 is compiling as C++.
 
 This isn't actually needed right now, but it's needed to experiment with Cython git master or if Cython releases a new version without fixing that bug.

Answer 10 · 2016-09-13T12:35:13.000Z

Description changed:

--- 
+++ 
@@ -1,3 +1 @@
-A workaround for https://github.com/cython/cython/issues/1433 is compiling as C++.
-
-This isn't actually needed right now, but it's needed to experiment with Cython git master or if Cython releases a new version without fixing that bug.
+Cython 0.25 is not released yet, but this branch collects changes that need to be made to Sage.

Answer 11 · 2016-09-13T12:35:13.000Z

Changed upstream from Reported upstream. No feedback yet. to none

Answer 12 · 2016-09-13T13:59:41.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`6e1a932`	`Move directives to cythonize() call`

Answer 13 · 2016-09-13T13:59:41.000Z

Changed commit from 766dfb0 to 6e1a932

Answer 14 · 2016-09-13T14:00:59.000Z

Description changed:

--- 
+++ 
@@ -1 +1,3 @@
 Cython 0.25 is not released yet, but this branch collects changes that need to be made to Sage.
+
+Cython 0.25 breaks `pyzmq`: https://github.com/zeromq/pyzmq/pull/909

Answer 15 · 2016-09-13T14:38:56.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`699f1f8`	`Move old_style_globals to modules; other directives to cythonize() call`

Answer 16 · 2016-09-13T14:38:56.000Z

Changed commit from 6e1a932 to 699f1f8

Answer 17 · 2016-09-13T15:26:28.000Z

Changed commit from 699f1f8 to 42d3e05

Answer 18 · 2016-09-13T15:26:28.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`42d3e05`	`Move old_style_globals to modules; other directives to cythonize() call`

Answer 19 · 2016-09-13T15:39:59.000Z

Changed commit from 42d3e05 to 00cd961

Answer 20 · 2016-09-13T15:39:59.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`00cd961`	`Fix build of pyzmq with Cython 0.25`

Answer 21 · 2016-09-14T06:02:15.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`102482c`	`Fix build of pyzmq with Cython 0.25`
`b888466`	`Move old_style_globals to modules; other directives to cythonize() call`

Answer 22 · 2016-09-14T06:02:15.000Z

Changed commit from 00cd961 to b888466

Answer 23 · 2016-09-26T15:20:23.000Z

Description changed:

--- 
+++ 
@@ -1,3 +1,5 @@
 Cython 0.25 is not released yet, but this branch collects changes that need to be made to Sage.
 
 Cython 0.25 breaks `pyzmq`: https://github.com/zeromq/pyzmq/pull/909
+
+**Tarball**: https://github.com/cython/cython/archive/0.25a0.tar.gz

Answer 24 · 2016-09-26T15:30:26.000Z

Description changed:

--- 
+++ 
@@ -2,4 +2,4 @@
 
 Cython 0.25 breaks `pyzmq`: https://github.com/zeromq/pyzmq/pull/909
 
-**Tarball**: https://github.com/cython/cython/archive/0.25a0.tar.gz
+**Tarball**: https://pypi.python.org/packages/5e/b0/56393f4518c56ed1572e68d1b43c99220feabf3d16465bfd0b39bb9d00fc/Cython-0.25a0.tar.gz

Answer 25 · 2016-09-26T15:34:02.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`5a55862`	`Fix build of pyzmq with Cython 0.25`
`85634c2`	`Upgrade Cython to version 0.25`
`5474247`	`Move old_style_globals to modules; other directives to cythonize() call`

Answer 26 · 2016-09-26T15:34:02.000Z

Changed commit from b888466 to 5474247

Answer 27 · 2016-09-27T09:27:57.000Z

Description changed:

--- 
+++ 
@@ -2,4 +2,4 @@
 
 Cython 0.25 breaks `pyzmq`: https://github.com/zeromq/pyzmq/pull/909
 
-**Tarball**: https://pypi.python.org/packages/5e/b0/56393f4518c56ed1572e68d1b43c99220feabf3d16465bfd0b39bb9d00fc/Cython-0.25a0.tar.gz
+**Tarball**: http://sage.ugent.be/www/jdemeyer/sage/Cython-0.25a0.tar.gz

Answer 28 · 2016-10-06T14:58:56.000Z

Dependencies: #21441

Answer 29 · 2016-10-06T15:01:02.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`ccd9442`	`Add a sage-pip-install wrapper for pip which handles uninstallation better.`
`29957fa`	`Various fixes and simplifications to sage-pip-install`
`783cd7d`	`Re-install all pip-installed packages`
`8fd8273`	`Fix various dependencies`
`a81f0b9`	`Fix build of pyzmq with Cython 0.25`
`07badbe`	`Upgrade Cython to version 0.25`
`fffc8d8`	`Move old_style_globals to modules; other directives to cythonize() call`

Answer 30 · 2016-10-06T15:01:02.000Z

Changed commit from 5474247 to fffc8d8

Answer 31 · 2016-10-18T07:42:05.000Z

Changed dependencies from #21441 to #21697

Answer 32 · 2016-10-18T07:45:59.000Z

Description changed:

--- 
+++ 
@@ -1,5 +1,5 @@
 Cython 0.25 is not released yet, but this branch collects changes that need to be made to Sage.
 
-Cython 0.25 breaks `pyzmq`: https://github.com/zeromq/pyzmq/pull/909
+Cython 0.25 breaks `pyzmq`, fixed by a `pyzmq` upgrade: #21697.
 
-**Tarball**: http://sage.ugent.be/www/jdemeyer/sage/Cython-0.25a0.tar.gz
+**Tarball**: https://github.com/cython/cython/archive/0.25b1.tar.gz

Answer 33 · 2016-10-18T07:49:18.000Z

Changed dependencies from #21697 to #21697, #21600

Answer 34 · 2016-10-18T08:19:13.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`636b22a`	`Upgrade to pyzmq 16.0.0`
`5ba95ed`	`Clean up stale installed files in install command`
`35ecf4b`	`Run cythonize() inside build_ext command`
`2b5fa98`	`Copy extra files to build directory instead of using data_files`
`dfcd817`	`extra_files -> sage_build_ext.cythonized_files`
`3d1cb63`	`Merge commit 'dfcd8177447c7eab491569f08777f585deda93ee' into t/20596/ticket/20596`
`a78498d`	`Upgrade Cython to version 0.25`
`ffbfdb8`	`Move old_style_globals to individual modules`

Answer 35 · 2016-10-18T08:19:13.000Z

Changed commit from fffc8d8 to ffbfdb8

Answer 36 · 2016-10-19T10:25:53.000Z

Description changed:

--- 
+++ 
@@ -2,4 +2,4 @@
 
 Cython 0.25 breaks `pyzmq`, fixed by a `pyzmq` upgrade: #21697.
 
-**Tarball**: https://github.com/cython/cython/archive/0.25b1.tar.gz
+**Tarball**: https://github.com/cython/cython/archive/0.25.x.zip

Answer 37 · 2016-10-19T12:18:31.000Z

Changed commit from ffbfdb8 to 6a9474b

Answer 38 · 2016-10-19T12:18:31.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`77eb8e2`	`Move old_style_globals to individual modules`
`6a9474b`	`Upgrade Cython to version 0.25`

Answer 39 · 2016-10-26T16:27:56.000Z

Description changed:

--- 
+++ 
@@ -2,4 +2,4 @@
 
 Cython 0.25 breaks `pyzmq`, fixed by a `pyzmq` upgrade: #21697.
 
-**Tarball**: https://github.com/cython/cython/archive/0.25.x.zip
+**Tarball**: https://pypi.python.org/packages/f8/2e/5898046f8089205981447c23ebb8fe02cd9d66939cd74338aa4872853d8e/Cython-0.25.tar.gz

Answer 40 · 2016-10-26T17:37:54.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`990c482`	`Upgrade Cython to version 0.25`

Answer 41 · 2016-10-26T17:37:54.000Z

Changed commit from 6a9474b to 990c482

Answer 42 · 2016-10-26T17:56:00.000Z

Description changed:

--- 
+++ 
@@ -1,5 +1,3 @@
-Cython 0.25 is not released yet, but this branch collects changes that need to be made to Sage.
-
 Cython 0.25 breaks `pyzmq`, fixed by a `pyzmq` upgrade: #21697.
 
 **Tarball**: https://pypi.python.org/packages/f8/2e/5898046f8089205981447c23ebb8fe02cd9d66939cd74338aa4872853d8e/Cython-0.25.tar.gz

Answer 43 · 2016-10-27T20:17:06.000Z

comment:29

I have seen 0.25.1 is out to fix some unexpected bugs, do we care?

Answer 44 · 2016-10-27T20:38:00.000Z

Description changed:

--- 
+++ 
@@ -1,3 +1 @@
-Cython 0.25 breaks `pyzmq`, fixed by a `pyzmq` upgrade: #21697.
-
-**Tarball**: https://pypi.python.org/packages/f8/2e/5898046f8089205981447c23ebb8fe02cd9d66939cd74338aa4872853d8e/Cython-0.25.tar.gz
+**Tarball**: https://pypi.python.org/packages/2f/ae/0bb6ca970b949d97ca622641532d4a26395322172adaf645149ebef664eb/Cython-0.25.1.tar.gz

Answer 45 · 2016-10-27T20:38:00.000Z

comment:30

Replying to @kiwifb:

I have seen 0.25.1 is out to fix some unexpected bugs, do we care?

I guess we should care.

Answer 46 · 2016-10-27T20:50:30.000Z

Changed commit from 990c482 to 922fa16

Answer 47 · 2016-10-27T20:50:30.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`922fa16`	`Upgrade Cython to version 0.25.1`

Answer 48 · 2016-10-27T21:25:00.000Z

comment:32

I am ready to put this in positive review unless you have something else to do before putting it back from "need_work" to "need_review".

Answer 49 · 2016-10-27T22:10:06.000Z

Reviewer: François Bissey

Answer 50 · 2016-10-27T22:10:06.000Z

comment:33

I guess I need to test Sage again with Cython 0.25.1. That will be not for today.

Answer 51 · 2016-10-29T14:26:47.000Z

Changed branch from u/jdemeyer/ticket/20596 to 922fa16