sagemath/sage

giac has undeclared dependency on libpng

jdemeyer opened this issue · 14 comments

CC: @frederichan-IMJPRG

Component: packages: standard

Keywords: atelierpari2017

Author: Jeroen Demeyer

Branch: 015a7d8

Reviewer: Jean-Pierre Flori

Issue created by migration from https://trac.sagemath.org/ticket/22163

New commits:

015a7d8giac depends on libpng

Commit: 015a7d8

Reviewer: Jean-Pierre Flori

comment:4

Does GIAC use -lpng1x rather than -lpng?
Or should we patch?

comment:5

during the spkg built my Makefile have this:

LIBS = -lrt -lpthread -ldl -lpng -lm -lmpfi -lmpfr -lgmp 
LIBTERMCAP = -ltermcap
comment:6

We probably should patch. But that's not an issue for this ticket.

comment:7

Ok so let's already merge this.

Changed keywords from none to atelierpari2017

comment:9

FYI, on OS X, configure finds the system libpng, looks for a main symbol in it which is not existent there, and just compiles without png support.

comment:10

Replying to @jpflori:

FYI, on OS X, configure finds the system libpng, looks for a main symbol in it which is not existent there, and just compiles without png support.

Up to now I think that it is not a problem to don't have png in giac from sage. giacpy or pynac are not using it.

Changed commit from 015a7d8 to none

comment:12

Replying to @frederichan-IMJPRG:

Up to now I think that it is not a problem to don't have png in giac from sage. giacpy or pynac are not using it.

For what it worth, for Sage Debian Live, i compile giac (from within Sage) with xcas support, by installing the system's fltk, remove the --disable flag and the nofltk-check.patch, so i guess for such a graphical use, png support could be useful.

What would be a correct patch (so that i can add it to SDL until it get fixed) ?