(experimental) Compile Cython code with binding=True

Question

(experimental) Compile Cython code with binding=True

jdemeyer opened this issue 9 years ago · 59 comments

When using the Cython compiler directive binding=True, Cython uses a custom type to implement functions and methods. This custom type supports more Python features. The most important changes lie in inspect support.

We find several Cython bugs regarding binding=True:

cython/cython#1658 (not an issue for Sage)
cython/cython#1724 (see #23155)
cython/cython#1728 (see #23155)

Depends on #25842
Depends on #25845
Depends on #25848

Upstream: Reported upstream. No feedback yet.

CC: @kwankyu

Component: cython

Author: Jeroen Demeyer

Branch/Commit: u/jdemeyer/ticket/22747 @ d962040

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/22747

Answer 1 · 2017-04-03T11:17:19.000Z

Description changed:

--- 
+++ 
@@ -1 +1 @@
-When using the Cython compiler directive `binding=True`, Cython uses a custom type to implement functions and methods. This custom type supports more Python features, such as `inspect` support.
+When using the Cython compiler directive `binding=True`, Cython uses a custom type to implement functions and methods. This custom type supports more Python features. The most important changes lie in `inspect` support.

Answer 2 · 2017-04-03T12:32:18.000Z

Branch: u/jdemeyer/ticket/22747

Answer 3 · 2017-04-03T15:39:22.000Z

Commit: 2b70327

Answer 4 · 2017-04-03T15:39:22.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`2b70327`	`Compile Cython code with binding=True`

Answer 5 · 2017-04-03T15:42:34.000Z

Description changed:

--- 
+++ 
@@ -1 +1,3 @@
 When using the Cython compiler directive `binding=True`, Cython uses a custom type to implement functions and methods. This custom type supports more Python features. The most important changes lie in `inspect` support.
+
+Unfortunately, this behaves badly if there are import cycles and there are many in Sage (#21636).

Answer 6 · 2017-04-20T09:40:23.000Z

Changed dependencies from #21682 to #21843

Answer 7 · 2017-04-20T09:57:00.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`b56b4be`	`Include Cython directives in .cython_version file`
`547397b`	`Compile Cython code with binding=True`

Answer 8 · 2017-04-20T09:57:00.000Z

Changed commit from 2b70327 to 547397b

Answer 9 · 2017-04-20T12:22:03.000Z

Description changed:

--- 
+++ 
@@ -1,3 +1,7 @@
 When using the Cython compiler directive `binding=True`, Cython uses a custom type to implement functions and methods. This custom type supports more Python features. The most important changes lie in `inspect` support.
 
 Unfortunately, this behaves badly if there are import cycles and there are many in Sage (#21636).
+
+We find several Cython bugs regarding `binding=True`:
+- https://github.com/cython/cython/issues/1658
+- https://github.com/cython/cython/issues/1679

Answer 10 · 2017-04-20T12:22:03.000Z

Upstream: Reported upstream. No feedback yet.

Answer 11 · 2017-04-20T15:01:34.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`ee13351`	`Compile Cython code with binding=True`

Answer 12 · 2017-04-20T15:01:34.000Z

Changed commit from 547397b to ee13351

Answer 13 · 2017-04-21T15:14:32.000Z

Changed dependencies from #21843 to #21843, #22852

Answer 14 · 2017-04-21T15:32:27.000Z

Changed commit from ee13351 to 93250a2

Answer 15 · 2017-04-21T15:32:27.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`841676d`	`Define functions before calling them`
`8994ace`	`Merge commit '841676d4931c9f59019b2b6b82afbbe7df222c10' into t/22747/ticket/22747`
`93250a2`	`Compile Cython code with binding=True`

Answer 16 · 2017-04-28T10:19:47.000Z

Changed commit from 93250a2 to 1e78314

Answer 17 · 2017-04-28T10:19:47.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`1e78314`	`Compile Cython code with binding=True`

Answer 18 · 2017-04-28T10:25:13.000Z

Changed dependencies from #21843, #22852 to none

Answer 19 · 2017-04-28T20:33:11.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`a57b913`	`QuotientRing_nc.ideal(): use super() instead of CommutativeRing`
`e62cc3a`	`Compile Cython code with binding=True`

Answer 20 · 2017-04-28T20:33:11.000Z

Changed commit from 1e78314 to e62cc3a

Answer 21 · 2017-06-02T19:45:43.000Z

Dependencies: #23103

Answer 22 · 2017-06-02T19:45:43.000Z

Description changed:

--- 
+++ 
@@ -3,5 +3,5 @@
 Unfortunately, this behaves badly if there are import cycles and there are many in Sage (#21636).
 
 We find several Cython bugs regarding `binding=True`:
-- https://github.com/cython/cython/issues/1658
-- https://github.com/cython/cython/issues/1679
+- https://github.com/cython/cython/issues/1658 (not a big problem for Sage)
+- https://github.com/cython/cython/pull/1724 (patch submitted upstream)

Answer 23 · 2017-06-02T19:47:22.000Z

Description changed:

--- 
+++ 
@@ -1,6 +1,4 @@
 When using the Cython compiler directive `binding=True`, Cython uses a custom type to implement functions and methods. This custom type supports more Python features. The most important changes lie in `inspect` support.
-
-Unfortunately, this behaves badly if there are import cycles and there are many in Sage (#21636).
 
 We find several Cython bugs regarding `binding=True`:
 - https://github.com/cython/cython/issues/1658 (not a big problem for Sage)

Answer 24 · 2017-06-02T21:12:09.000Z

Changed commit from e62cc3a to 680f4a7

Answer 25 · 2017-06-02T21:12:09.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`256bf19`	`Move richcmp stuff to new file richcmp.pyx`
`7629851`	`Merge tag '8.0.beta9' into t/23103/move_richcmp_stuff_to_new_file`
`031761f`	`Fix two more imports`
`f159d41`	`Add Cython patch to fix decorators with binding=True`
`680f4a7`	`Compile Cython code with binding=True`

Answer 26 · 2017-06-06T09:37:05.000Z

Changed dependencies from #23103 to #23103, #23122

Answer 27 · 2017-06-06T15:46:53.000Z

Changed commit from 680f4a7 to b24e4c8

Answer 28 · 2017-06-06T15:46:53.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`d59afe3`	`Load the correct zlib library`
`db3b5eb`	`Merge commit '031761f6ead116e4fa0a0fd3bf21fca5546df6d7' into HEAD`
`4c5cc9c`	`Add Cython patch to fix decorators with binding=True`
`116030b`	`Compile Cython code with binding=True`
`b24e4c8`	`Sage library fixes for binding=True`

Answer 29 · 2017-06-06T19:33:52.000Z

Description changed:

--- 
+++ 
@@ -2,4 +2,4 @@
 
 We find several Cython bugs regarding `binding=True`:
 - https://github.com/cython/cython/issues/1658 (not a big problem for Sage)
-- https://github.com/cython/cython/pull/1724 (patch submitted upstream)
+- https://github.com/cython/cython/pull/1724 (patch submitted upstream, no feedback yet)

Answer 30 · 2017-06-07T08:10:30.000Z

Changed dependencies from #23103, #23122 to #23103, #23122, #23155, #15947

Answer 31 · 2017-06-07T08:10:30.000Z

Description changed:

--- 
+++ 
@@ -1,5 +1,5 @@
 When using the Cython compiler directive `binding=True`, Cython uses a custom type to implement functions and methods. This custom type supports more Python features. The most important changes lie in `inspect` support.
 
 We find several Cython bugs regarding `binding=True`:
-- https://github.com/cython/cython/issues/1658 (not a big problem for Sage)
-- https://github.com/cython/cython/pull/1724 (patch submitted upstream, no feedback yet)
+- https://github.com/cython/cython/issues/1658 (not an issue for Sage)
+- https://github.com/cython/cython/pull/1724 (see #23155)

Answer 32 · 2017-06-07T11:20:27.000Z

Description changed:

--- 
+++ 
@@ -3,3 +3,4 @@
 We find several Cython bugs regarding `binding=True`:
 - https://github.com/cython/cython/issues/1658 (not an issue for Sage)
 - https://github.com/cython/cython/pull/1724 (see #23155)
+- https://github.com/cython/cython/pull/1728 (see #23155)

Answer 33 · 2017-06-07T13:49:25.000Z

Changed dependencies from #23103, #23122, #23155, #15947 to #23103, #23122, #23155, #15947, #23159

Answer 34 · 2017-06-07T20:48:34.000Z

Changed commit from b24e4c8 to 37975ed

Answer 35 · 2017-06-07T20:48:34.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`2e2339b`	`Add Cython patch to fix decorators with binding=True`
`091657d`	`Add Cython patch to fix method calls with binding=True`
`8f29430`	`_lmul_ and _rmul_: scalar should be Element instead of RingElement`
`d288f41`	`Give deprecation warning for #5930 unconditionally`
`6bd7e9f`	`Merge commit '031761f6ead116e4fa0a0fd3bf21fca5546df6d7'; commit 'd59afe3bf4ee03da91184ae6183a6dd6a9d3656f'; commit '091657d270e422bfc7f27efa7d6944a5c3fd96f2'; commit '8f294308f8b85b233ffdc9df3f20c404ee6431c9'; commit 'd288f414bf0f8d785c1928fd1bdce89ec1bdc033' into HEAD`
`8ebd184`	`Compile Cython code with binding=True`
`37975ed`	`Sage library fixes for binding=True`

Answer 36 · 2017-08-22T13:54:33.000Z

Changed commit from 37975ed to 90e7db1

Answer 37 · 2017-08-22T13:54:33.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`8a5bb48`	`Compile Cython code with binding=True`
`90e7db1`	`Sage library fixes for binding=True`

Answer 38 · 2017-08-22T15:07:37.000Z

Changed commit from 90e7db1 to 4062ec6

Answer 39 · 2017-08-22T15:07:37.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`4062ec6`	`Sage library fixes for binding=True`

Answer 40 · 2018-07-11T08:12:25.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`94ab6e0`	`Compile Cython code with binding=True`
`dba0dd6`	`Sage library fixes for binding=True`

Answer 41 · 2018-07-11T08:12:25.000Z

Changed commit from 4062ec6 to dba0dd6

Answer 42 · 2018-07-11T09:21:53.000Z

Changed dependencies from #23103, #23122, #23155, #15947, #23159 to none

Answer 43 · 2018-07-12T10:38:45.000Z

Changed commit from dba0dd6 to 0f70aed

Answer 44 · 2018-07-12T10:38:45.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`f1debe3`	`Upgrade to Cython 0.28.4`
`ee4c6c4`	`Compile Cython code with binding=True`
`aa3513f`	`Sage library fixes for binding=True`
`0f70aed`	`Try to fix Set_PythonType`

Answer 45 · 2018-07-12T14:10:58.000Z

Changed commit from 0f70aed to 60007d5

Answer 46 · 2018-07-12T14:10:58.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`6310172`	`Fix a cyclic import involving interval fields`
`60007d5`	`Move Set_PythonType to a new file`

Answer 47 · 2018-07-12T14:32:52.000Z

Changed commit from 60007d5 to 13068eb

Answer 48 · 2018-07-12T14:32:52.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`13068eb`	`Move Set_PythonType to a new file`

Answer 49 · 2018-07-12T14:33:10.000Z

Dependencies: #25845

Answer 50 · 2018-07-12T14:47:05.000Z

Changed commit from 13068eb to ddb7cc8

Answer 51 · 2018-07-12T14:47:05.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`7e7daef`	`Move Set_PythonType to a new file`
`48f170f`	`Compile Cython code with binding=True`
`46a7887`	`Sage library fixes for binding=True`
`ddb7cc8`	`Fix a cyclic import involving interval fields`

Answer 52 · 2018-07-13T09:20:11.000Z

Changed commit from ddb7cc8 to 5282f12

Answer 53 · 2018-07-13T09:20:11.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`8756c40`	`Some preparations for binding=True`
`5282f12`	`Sage library fixes for binding=True`

Answer 54 · 2018-07-13T09:20:40.000Z

Changed commit from 5282f12 to d962040

Answer 55 · 2018-07-13T09:20:40.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`742e1c9`	`Some preparations for binding=True`
`c5a8bd3`	`Compile Cython code with binding=True`
`d962040`	`Sage library fixes for binding=True`

Answer 56 · 2018-07-13T09:21:22.000Z

Changed dependencies from #25845 to #25842, #25845, #25848

Answer 57 · 2021-09-13T19:24:27.000Z

comment:36

We can close this ticket in favor of #26254.

The only commit from the branch here that is useful is sagemath/sagetrac-mirror@d962040 -- not really "Sage library fixes" but just some updates of doctest outputs.

Answer 58 · 2021-11-20T22:41:08.000Z

comment:37

Ok, #26254 looks much further along.

Answer 59 · 2021-11-20T22:41:08.000Z

Reviewer: Michael Orlitzky