Interface cases function with SymPy's piecewise

Question

Interface cases function with SymPy's piecewise

rwst opened this issue 8 years ago · 16 comments

In #20191 the cases function is introduced. This ticket should interface it with SymPy's piecewise (both directions) and test with:

        sage: _ = var('y, z')
        sage: (x^y - z).integrate(y)
        -y*z + x^y/log(x)
        sage: (x^y - z).integrate(y, algorithm="sympy")  # see Trac #14694
        -y*z + cases(((log(x) == 0, y), (1, x^y/log(x))))

Depends on #20191
Depends on #23990
Depends on #24006

CC: @mforets @EmmanuelCharpentier

Component: interfaces

Author: Ralf Stephan

Branch/Commit: b261ec3

Reviewer: Emmanuel Charpentier

Issue created by migration from https://trac.sagemath.org/ticket/23923

Answer 1 · 2017-10-08T14:22:02.000Z

Changed dependencies from #20191 to #20191, #23990

Answer 2 · 2017-10-08T14:23:28.000Z

Branch: u/rws/interface_cases_function_with_sympy_s_piecewise

Answer 3 · 2017-10-09T20:36:32.000Z

Commit: ea10ee7

Answer 4 · 2017-10-09T20:36:32.000Z

New commits:

`ea10ee7`	`23923: interface cases() with SymPy`

Answer 5 · 2017-10-17T06:04:03.000Z

Changed branch from u/rws/interface_cases_function_with_sympy_s_piecewise to u/rws/23923

Answer 6 · 2017-10-17T06:05:29.000Z

Changed commit from ea10ee7 to b80d98c

Answer 7 · 2017-10-17T06:05:29.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`b80d98c`	`23923: fix typo`

Answer 8 · 2017-10-17T06:07:10.000Z

Author: Ralf Stephan

Answer 9 · 2017-10-17T06:07:10.000Z

Changed dependencies from #20191, #23990 to #20191, #23990, #24006

Answer 10 · 2017-10-17T15:34:03.000Z

comment:7

On top of 8.1beta7+#24026 + #24006(dependency) + #23990(dependency) + #23923(present patch), one permanent failure :

sage -t --long src/sage/symbolic/integration/integral.py
**********************************************************************
File "src/sage/symbolic/integration/integral.py", line 508, in sage.symbolic.int
egration.integral.integrate
Failed example:
    (x^y - z).integrate(y, algorithm="sympy")  # see Trac #14694
Expected:
    Traceback (most recent call last):
    ...
    AttributeError: 'ExprCondPair' object has no attribute '_sage_'
Got:
    -y*z + cases(((log(x) == 0, y), (1, x^y/log(x))))
**********************************************************************
1 item had failures:
   1 of 126 in sage.symbolic.integration.integral.integrate
    [169 tests, 1 failure, 53.41 s]

==>needs_work. Probably a booboo, though...

Answer 11 · 2017-10-17T16:09:22.000Z

Changed commit from b80d98c to b261ec3

Answer 12 · 2017-10-17T16:09:22.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`b261ec3`	`23923: fix doctest`

Answer 13 · 2017-10-17T21:16:42.000Z

comment:10

On top of 8.1beta8+#24026 + #24006(dependency) + #23990(dependency) + #23923(present patch), passes ptestlong with no error whatsoever.

==>positive_review

Notes :

I rebased the test on the hust-issued 8.1.beta8
I have kept #24026 (which needs_review, BTW...) because removing it entails recompiling R (which is slow) and reinstall 442 R packages, (which is slower...).

Answer 14 · 2017-10-18T06:08:01.000Z

Reviewer: Emmanuel Charpentier

Answer 15 · 2017-10-18T06:08:01.000Z

comment:11

Thanks. I've added your name, hope it's not impolite.

Answer 16 · 2017-10-30T07:41:21.000Z

Changed branch from u/rws/23923 to b261ec3