sagemath/sage

sagenb 1.1.0

dimpase opened this issue · 25 comments

a routine update, incorporating most urgent PRs.

Also, in view of #25382

tarball:
https://github.com/sagemath/sagenb/releases/download/1.1.0/sagenb-1.1.0.tar.bz2

Depends on #24692
Depends on #25382

CC: @kiwifb

Component: packages: standard

Author: Dima Pasechnik

Branch: 20b0980

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/26499

comment:1

should we also do the downgrade to optional here?

comment:3

should we also do the downgrade to optional here?

You mean downgrading the spkg to optional? Is that actually possible already?

comment:4

Could someone with python3 sage test this?

comment:5

Replying to @timokau:

should we also do the downgrade to optional here?

You mean downgrading the spkg to optional? Is that actually possible already?

Sorry, no, not yet. I forgot about #25837.

comment:6

Replying to @dimpase:

Could someone with python3 sage test this?

There is no need to test with python3: I know that launching sagenb will fail when trying to import "email" module. I would say that py3-compatibility of sagenb has never been closer, but there is still work, and no worker to handle the task..

comment:7

I'm adding docs, please stand by...

Description changed:

--- 
+++ 
@@ -1,3 +1,6 @@
 a routine update, incorporating most urgent PRs.
 
-tarball: https://github.com/sagemath/sagenb/releases/download/1.0.4/sagenb-1.0.4.tar.bz2
+Also, in view of #25382
+
+tarball: 
+https://github.com/sagemath/sagenb/releases/download/1.1.0/sagenb-1.1.0.tar.bz2

Commit: 0f1fbf2

New commits:

7adac2cupdate sagenb to version 1.0.4
059de77trac 25382: remove the sagenb docs from the reference manual.
591e91atrac 25382 remove remaining crosslinks
e2ff902Merge branch 'public/25382' of trac.sagemath.org:sage into nb104
80beebbUpgrade GDB
6769112updated SPKG.txt to note the need for makeinfo
17ab2ceMerge branch 'public/packages/optional/gdb82' of trac.sagemath.org:sage into nb104
0f1fbf2added docs of sagenb

Dependencies: #24692, #25382

comment:12

admittedly, docs are packed with few short autogenerated .rst files; if anyone is willing to tell me how to use sphinx to generate these, be my guest, I can fix this then.

comment:13

I presume sagenb should now also depend on sphinx, there may be transitive dependency from something else but it is not visible.

Changed commit from 0f1fbf2 to 20b0980

Branch pushed to git repo; I updated commit sha1. New commits:

20b0980sphinx must be a dependency
comment:15

Replying to @kiwifb:

I presume sagenb should now also depend on sphinx, there may be transitive dependency from something else but it is not visible.

Indeed. Thanks for pointing this out. Fixed in the last commit.

comment:16

Do we go ahead with this or are we waiting for further changes?

comment:17

Well, I am waiting for a review on this ticket... :-)

comment:18

Looks good to me then :)

Reviewer: François Bissey

Changed branch from u/dimpase/packages/sagenb110 to 20b0980

Changed commit from 20b0980 to none

comment:20

How was the "source tarball" ​https://github.com/sagemath/sagenb/releases/download/1.1.0/sagenb-1.1.0.tar.bz2 created? It doesn't correspond with the github repo. In particular, the repo does not contain a bundled mathjax (as it should be), while the "source tarball" does.

Please comment at #26641.

comment:21

I assume that the "source tarball" from this ticket was created from a non-clean checkout of the sagenb repo. I'll fix that on #26641.

comment:22

It has been created using the standard procedure as explained in sagenb hacking docs and uploaded to GitHub.

Naturally it is not quite the same as what you have in GitHub report.