spkg-configure.m4 for bzip2
embray opened this issue · 15 comments
Spun off from #27168.
Component: packages: standard
Author: Erik Bray, Dima Pasechnik
Branch: 4ec5dc0
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/27182
This also reminds me, we probably should add a section in the installation docs (especially for Linux) listing optional -devel packages that should be installed in order to take advantage of supported system packages where possible.
For testing tickets like this it's best to start from a fresh install, since otherwise I think, even if the ./configure script now detects your system's bzip2, it's not like it will uninstall the package already installed spkg.
Tested a fresh build and ptestlong with my system's bzip2 (also 1.0.6). Actually, I think this software's creator has stopped maintaining it. There was some discussion about that a bit ago on the Cygwin mailing list IIRC.
the branch does not seem to contain spkg-configure.m4 :-)
(at least using the trac view)
No, it's just not there. Forgotten commit?
Lol. Must be a forgotten git add.
Branch pushed to git repo; I updated commit sha1. New commits:
4ec5dc0 | Trac #27182: add configure-time detection of the system's libbz2 |
Reviewer: Dima Pasechnik
Changed branch from u/embray/build/bzip2-spkg-configure to 4ec5dc0
Sanity check: does that last AC_CHECK_PROG really do what it's supposed to?
SAGE_SPKG_CONFIGURE([bzip2], [
AC_CHECK_HEADER(bzlib.h, [], [sage_spkg_install_bzip2=yes])
AC_SEARCH_LIBS([BZ2_bzCompress], [bz2], [], [sage_spkg_install_bzip2=yes])
AC_CHECK_PROG(bzip2, [break], [sage_spkg_install_bzip2=yes])
])
Replying to @orlitzky:
Sanity check: does that last AC_CHECK_PROG really do what it's supposed to?
SAGE_SPKG_CONFIGURE([bzip2], [ AC_CHECK_HEADER(bzlib.h, [], [sage_spkg_install_bzip2=yes]) AC_SEARCH_LIBS([BZ2_bzCompress], [bz2], [], [sage_spkg_install_bzip2=yes]) AC_CHECK_PROG(bzip2, [break], [sage_spkg_install_bzip2=yes]) ])
hmm, no. It should be AC_PATH_PROG([BZIP2], [bzip2], [sage_spkg_install_bzip2=yes])
- the test as specified always passes.