sagemath/sage

use system's gf2x if available

dimpase opened this issue · 16 comments

dimpase commented

the usual spkg-configure.m4 thing

CC: @embray @kiwifb

Component: packages: standard

Author: Dima Pasechnik

Branch: 844e241

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/27238

dimpase commented
comment:2

the test is not sufficient to tell version 1.2 from 1.1

dimpase commented

Dependencies: #27212

dimpase commented
comment:5

One ought to be able to test for signature of a particular function in gf2x.h, which changed from 1.1 to 1.2.

sagetrac-git commented

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a1ee9bdspkg-configure.m4 for gf2x
6b61156added a test for version >= 1.2
sagetrac-git commented

Changed commit from dbd7476 to 6b61156

dimpase commented
comment:7

gf2x takes long time to build, as it does tuning, so that's quite a building speedup.

dimpase commented

Changed dependencies from #27212 to none

kiwifb commented
comment:10

Is there a mix of tabs and white spaces in that file? Just looking at it in the browser, I didn't checkout the branch. Other than that it looks sound and should do the trick.

sagetrac-git commented

Branch pushed to git repo; I updated commit sha1. New commits:

844e241whitespaces adjusted, tabs removed
sagetrac-git commented

Changed commit from 6b61156 to 844e241

dimpase commented
comment:12

fixed whitespaces now, sorry.

kiwifb commented
comment:13

Those things are quite clear on the diff but I think they are harmless in M4. Let's move on.

kiwifb commented

Reviewer: François Bissey

dimpase commented
comment:15

I've provided the upstream with a PR to do a pkg-config configuration, so this could be simplified eventually. See
dimpase/gf2x@c7cd1f2
and
https://gforge.inria.fr/tracker/index.php?func=detail&aid=21746&group_id=1874&atid=6979

dimpase commented

Changed commit from 844e241 to none