spkg-configure.m4 for ecm
dimpase opened this issue · 31 comments
it needs gmp, and is not a dependency of anything (besides sagelib)
To get this package on the system:
- Fedora: gmp-ecm-devel
- Gentoo: gmp-ecm - (but the version is too old in the main tree. Decent one in the sage-on-gentoo overlay)
- FreeBSD: gmp-ecm
Component: build
Author: Dima Pasechnik
Branch/Commit: 96ade1f
Reviewer: Isuru Fernando
Issue created by migration from https://trac.sagemath.org/ticket/27271
Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)
Branch: u/dimpase/packages/ecmconfig
checking the version by grepping the header, duh...
Last 10 new commits:
b80bf72 | Reworked this a bit more |
0ca3f56 | fix typo |
06798ca | added a bit more explanation |
b592d77 | correct logic for SAGE_GMP_PREFIX etc |
5057680 | add the AX_ABSOLUTE_HEADER macro |
101537b | iml in particular is very picky about being given an absolute path to the |
862ca6a | Merge remote-tracking branch 'trac/develop' into HEAD |
03dc987 | Merged trac #27215 in |
98c67d3 | Merge remote-tracking branch 'trac/public/packages/gmp_m4' into ecm-config |
7d1f15e | spkg-configure for ecm |
Does this really depend on #27212? I ask just because it's not clear to me exactly how, and this might be useful on its own as well.
Replying to @embray:
Does this really depend on #27212? I ask just because it's not clear to me exactly how, and this might be useful on its own as well.
gmp/mpir is a dependency of ecm! (and so not using system's gmp/mpir and using the system's gmp/mpir for ecm would lead to a lot of linking/loading "fun" with sagelib)
As for the contents of the ecm/spkg-configure.m4 itself, it looks fine to me at first glance, an I trust you've tested it.
A slightly more "sophisticated" approach might be build a test program which prints the value of the version, but in this case it's simple enough that just grepping for it should be good enough.
I am going to submit an upstream patch to get a pkg-config configuration for ecm
(more or less the same INRIA upstream accepted such patch for gf2x, so this will make this much easier, once in).
Replying to @dimpase:
Replying to @embray:
Does this really depend on #27212? I ask just because it's not clear to me exactly how, and this might be useful on its own as well.
gmp/mpir is a dependency of ecm! (and so not using system's gmp/mpir and using the system's gmp/mpir for ecm would lead to a lot of linking/loading "fun" with sagelib)
I see. In that case (and we still need a generic way to do this but I think it's tricky), the ecm/spkg-configure.m4 should do
AC_REQUIRE([SAGE_SPKG_CONFIGURE_GMP])
and then refuse to use the system package if sage_spkg_install_mpir = yes or sage_spkg_install_gmp = yes.
OK, so the latter applies to other tickets that have #27212 as a dependence.
rebased over 8.8.beta5 and added the missing test. Can be reviewed now.
Description changed:
---
+++
@@ -1 +1,7 @@
it needs gmp, and is not a dependency of anything (besides sagelib)
+
+To get this package on the system:
+
+* Fedora: gmp-ecm-devel
+* Gentoo: gmp-ecm - (but the version is too old, why?)
+* FreeBSD: gmp-ecmDescription changed:
---
+++
@@ -3,5 +3,5 @@
To get this package on the system:
* Fedora: gmp-ecm-devel
-* Gentoo: gmp-ecm - (but the version is too old, why?)
+* Gentoo: gmp-ecm - (but the version is too old in the main tree. Decent one in the sage-on-gentoo overlay)
* FreeBSD: gmp-ecmalso need to check for ecm executable. Something like
$ echo 121 | ecm 4 | grep "GMP-ECM"
GMP-ECM 7.0.4 [configured with GMP 6.1.2, --enable-asm-redc] [ECM]
needs review again.
Not sure if it's related to this ticket or not (it wouldn't be caused by it as it hasn't had positive_review yet, but I mean it might be relevant), but I'm seeing some problems on Cygwin with the ECM make check test suite, which I don't think I had problems with before (I did not list ECM in #22866).
I think I might still need to go ahead and make building MPIR a requirement on Cygwin for now anyways. I'll try to investigate this once I can to a state where everything else isn't broken :(
rebased oved 8.8.rc0
Moving tickets from the Sage 8.8 milestone that have been actively worked on in the last six months to the next release milestone (optimistically).
Picks up the conda package correctly.
Reviewer: Isuru Fernando
rebased over Sage 8.9.beta3, just in case.
Changed branch from u/dimpase/packages/ecmconfig to 96ade1f