correct the test for galpol package in pari's spkg-configure.m4
Closed this issue · 10 comments
the test written there
if test "x$gp_galp_check = xC3\ \:\ C4"; thenalways evaluates to true.
It is meant to check whether gp_galp_check (which may be empty) equals the string
"C3 : C4"
CC: @embray @kiwifb @isuruf @videlec
Component: build: configure
Author: Dima Pasechnik
Branch/Commit: 7d01e58
Reviewer: Isuru Fernando
Issue created by migration from https://trac.sagemath.org/ticket/28405
Description changed:
---
+++
@@ -1,9 +1,9 @@
the test written there
-```
+```bash
if test "x$gp_galp_check = xC3\ \:\ C4"; then
```
always evaluates to true.
-It is meant to check whether `gp_galp_check` equals the string
+It is meant to check whether `gp_galp_check` (which may be empty) equals the string
`"C3 : C4"`
my patchy knowledge of autoconf/m4/shell syntax does not suffice, please help...
Shouldn't it be
"x$gp_galp_check" = "xC3 : C4"
?
Branch: u/dimpase/packages/paritestfix
Author: Dima Pasechnik
I've moved the test into the call to gp, now it works.
New commits:
7d01e58 | let gp do the check and return 0/1 |
Reviewer: Isuru Fernando
I can confirm the issue and that this ticket correctly detects that galpol is not installed.
Changed branch from u/dimpase/packages/paritestfix to 7d01e58