Doctesting: don't test SageNB files unless SageNB has been installed
Closed this issue · 7 comments
Since SageNB is now an optional package, we should detect whether it's present before doctesting its files via make ptestlong and similar commands.
Component: doctest framework
Author: John Palmieri
Branch/Commit: a579a9a
Reviewer: Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/28834
Branch: u/jhpalmieri/dont_doctest_sagenb
Commit: a579a9a
Without these changes, a Python 2 build of Sage fails to run doctests. With these changes, tests pass for me with a plain Python 2 build and also after running ./sage -i sagenb. Before running ./sage -i sagenb, make ptestlong says
Doctesting 3796 files using 12 threads...
(Same with Python 2 or Python 3)
After running ./sage -i sagenb, with Python 2:
Doctesting 3849 files using 12 threads...
So it appears that the extra files are being correctly detected and doctested.
New commits:
a579a9a | trac 28834: doctesting: detect whether sagenb is installed |
Reviewer: Frédéric Chapoton
ok, seems a reasonable thing to do
appears to work in Python2 with and without sagenb installed.
Changed branch from u/jhpalmieri/dont_doctest_sagenb to a579a9a