sagemath/sage

spkg-configure.m4 for gc

Closed this issue · 34 comments

Split off of #28045, where the libatomic dependency is handled.

CC: @embray @dimpase @isuruf

Component: build: configure

Author: Thierry Thomas, Dima Pasechnik

Branch: d5c10a5

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/28991

Changed dependencies from 28045 to #28045

comment:2

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

spkg-configure.m4 to be copied under build/pkgs/gc

comment:3

Attachment: spkg-configure.m4.gz

With the attached spkg-configure.m4, it works for me on FreeBSD, and Sage uses the system package.

Note: ATM the FreeBSD system package is at v.8.0.4 (boehm-gc-threaded-8.0.4_1), and the pkg-config file is named bdw-gc-threaded.pc - this might be different on other systems.

comment:4

It's bdw-gc.pc on Gentoo at least, so we should check that name too.

comment:5

Replying to @orlitzky:

It's bdw-gc.pc on Gentoo at least, so we should check that name too.

also on Debian and Fedora it is bdw-gc.

  • on Debian on needs to install libgc-dev
  • on Fedora one needs to install gc gc-devel

Author: Thierry Thomas, Dima Pasechnik

Changed dependencies from #28045 to none

Commit: 5a6ce6f

New commits:

5a6ce6fspkg-configure for boehm gc
comment:7

GH Actions run?

comment:8

Works on Gentoo now, thanks!

Changed commit from 5a6ce6f to 9e334dd

Branch pushed to git repo; I updated commit sha1. New commits:

9e334ddmore hints for libatomic_ops on distros
comment:11

as can be seen on the GH Action logs from https://github.com/dimpase/sage/actions/runs/207790649 libgc is correctly recongnised - if it can be installed

On macOS Conda, libgc is not found:
https://github.com/dimpase/sage/runs/982690154

  - https://repo.anaconda.com/pkgs/main/osx-64
  - https://repo.anaconda.com/pkgs/main/noarch
  - https://repo.anaconda.com/pkgs/r/osx-64
  - https://repo.anaconda.com/pkgs/r/noarch

To search for alternate channels that may provide the conda package you're
looking for, navigate to

    https://anaconda.org

and use the search bar at the top of the page.


ERROR: InvocationError for command /bin/bash -c 'PACKAGES=`sed "s/#.*//;" build/pkgs/*/distros/conda.txt`; . /Users/runner/work/sage/sage/.tox/local-conda-forge-macos-standard/conda/bin/activate && /Users/runner/work/sage/sage/.tox/local-conda-forge-macos-standard/conda/bin/conda install --yes --quiet $PACKAGES' (exited with code 1)
___________________________________ summary ____________________________________
ERROR:   local-conda-forge-macos-standard: commands failed
##[error]Process completed with exit code 1.

Isuru, do you get an idea what's wrong here?

comment:14

I will remove conda.txt

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

eb2ca1dspkg-configure for boehm gc
7d85242more hints for libatomic_ops on distros
6b89b6dleave conda out for the time being

Changed commit from 9e334dd to 6b89b6d

comment:16

commented out conda, rebased over 9.2.beta11.

comment:17

GH run please

Branch pushed to git repo; I updated commit sha1. New commits:

d5c10a5also no gc on conda

Changed commit from 6b89b6d to d5c10a5

comment:19

Replying to @mkoeppe:

GH run please

see #98

comment:20

ping?

Reviewer: Michael Orlitzky

comment:21

LGTM, but can you just delete those conda.txt files rather than comment out their contents? If I'm looking for packages that need Gentoo information, I'm going to be checking for the existence of distros/gentoo.txt and assume that it's correct if present.

comment:22

Thanks!

As to deleting, we already have quite a few of distros/foo.txt with commented out content, e.g. build/pkgs/arb/distros/homebrew.txt, so, no, the content of these files matters matters :-)

Changed commit from d5c10a5 to none

comment:24

Looks like this may have caused the breakage reported in #30629 (wsl-ubuntu-focal: ECL build fails).

comment:25

Replying to @mkoeppe:

Looks like this may have caused the breakage reported in #30629 (wsl-ubuntu-focal: ECL build fails).

it appears that all the released versions of gc suffer from the problem at hand, no?

comment:26

If I understand the issue correctly, it's a particular libgc configuration used on Ubuntu 20.04 that is the problem.