Add GitHub CI workflow for cygwin

Question

Add GitHub CI workflow for cygwin

mkoeppe opened this issue 6 years ago · 35 comments

Using choco instead of apt-cyg because it is available out of the box on GitHub Actions, and can install cygwin unattended.

CC: @embray

Component: porting: Cygwin

Author: Matthias Koeppe

Branch/Commit: 85b3c3d

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29295

Answer 1 · 2020-03-08T02:52:55.000Z

Branch: u/mkoeppe/29106+ci

Answer 2 · 2020-03-08T02:55:48.000Z

Commit: 08279dc

Answer 3 · 2020-03-08T02:55:48.000Z

Author: Matthias Koeppe

Answer 4 · 2020-03-08T02:55:48.000Z

Last 10 new commits:

`d110ad6`	`use bash -l`
`a8f1400`	`chdir`
`877cc43`	`save pwd`
`9c8ea73`	`no autocrlf`
`6703eb9`	`save pwd`
`f6000b4`	`fixup, prepare log artifact`
`ceb422c`	`fixup`
`144da9e`	`use cygpath`
`b47e23a`	`debug`
`08279dc`	`do not fail fast`

Answer 5 · 2020-03-08T02:55:48.000Z

Description changed:

--- 
+++ 
@@ -1 +1,2 @@
+Using choco instead of apt-cyg because it is available out of the box on [GitHub](../wiki/GitHub) Actions, and can install cygwin unattended.

Answer 6 · 2020-03-08T03:03:31.000Z

comment:3

This works pretty well already (https://github.com/mkoeppe/sage/runs/492908952?check_suite_focus=true)

Issues:

configure is run a second time at the beginning of make
a non-Cygwin python is in PATH and is picked up by sage-system-python. This should really be fixed by #29090 ("configure forgets to check whether ANY Python is available on the system").

Answer 7 · 2020-03-08T05:13:20.000Z

Changed commit from 08279dc to b212213

Answer 8 · 2020-03-08T05:13:20.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`2603562`	`Reset PATH so that only cygwin binaries are used`
`f17762d`	`Simplify`
`b212213`	`build/pkgs/cygwin.txt: gcc -> gcc-core, gcc-c++`

Answer 9 · 2020-03-09T01:14:46.000Z

comment:5

Tests at https://github.com/mkoeppe/sage/actions/runs/51902280

Answer 10 · 2020-03-09T01:17:00.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`d38b04b`	`git config --global core.symlinks true`

Answer 11 · 2020-03-09T01:17:00.000Z

Changed commit from b212213 to d38b04b

Answer 12 · 2020-03-12T22:13:07.000Z

comment:7

I see here in the log some probably known to Erik issue, crypt module does not build for py3

building '_crypt' extension
gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wno-unused -std=c99 -Wextra -Wno-unused-result -Wno-unused-parameter -Wno-missing-field-initializers -Wno-cast-function-type -Werror=implicit-function-declaration -I./Include -I/cygdrive/d/a/sage/sage/local/include -I. -I/cygdrive/d/a/sage/sage/local/var/tmp/sage/build/python3-3.7.3.p1/src/Include -I/cygdrive/d/a/sage/sage/local/var/tmp/sage/build/python3-3.7.3.p1/src -c /cygdrive/d/a/sage/sage/local/var/tmp/sage/build/python3-3.7.3.p1/src/Modules/_cryptmodule.c -o build/temp.cygwin-3.1.4-x86_64-3.7/cygdrive/d/a/sage/sage/local/var/tmp/sage/build/python3-3.7.3.p1/src/Modules/_cryptmodule.o
gcc -shared -Wl,--enable-auto-image-base -L/cygdrive/d/a/sage/sage/local/lib -Wl,-rpath,/cygdrive/d/a/sage/sage/local/lib -L. -L/cygdrive/d/a/sage/sage/local/lib -Wl,-rpath,/cygdrive/d/a/sage/sage/local/lib -L. -L/cygdrive/d/a/sage/sage/local/lib -Wl,-rpath,/cygdrive/d/a/sage/sage/local/lib build/temp.cygwin-3.1.4-x86_64-3.7/cygdrive/d/a/sage/sage/local/var/tmp/sage/build/python3-3.7.3.p1/src/Modules/_cryptmodule.o -L. -L/cygdrive/d/a/sage/sage/local/lib -L/usr/local/lib -L. -lpython3.7m -o build/lib.cygwin-3.1.4-x86_64-3.7/_crypt.dll
/usr/lib/gcc/x86_64-pc-cygwin/9.2.0/../../../../x86_64-pc-cygwin/bin/ld: build/temp.cygwin-3.1.4-x86_64-3.7/cygdrive/d/a/sage/sage/local/var/tmp/sage/build/python3-3.7.3.p1/src/Modules/_cryptmodule.o: in function `crypt_crypt_impl':
/cygdrive/d/a/sage/sage/local/var/tmp/sage/build/python3-3.7.3.p1/src/Modules/_cryptmodule.c:43: undefined reference to `crypt'
/cygdrive/d/a/sage/sage/local/var/tmp/sage/build/python3-3.7.3.p1/src/Modules/_cryptmodule.c:43:(.text+0x3a): relocation truncated to fit: R_X86_64_PC32 against undefined symbol `crypt'
collect2: error: ld returned 1 exit status

maybe it's just a forgotten Cygwin package:
https://cygwin.com/packages/summary/libcrypt0.html ?

Answer 13 · 2020-03-12T22:17:02.000Z

comment:8

See also #29012

Answer 14 · 2020-03-12T22:37:22.000Z

Changed commit from d38b04b to 36f7b59

Answer 15 · 2020-03-12T22:37:22.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`0f70082`	`build/pkgs/cygwin.txt: gcc -> gcc-core, gcc-c++`
`47e4395`	`build/pkgs/cygwin.txt: Add libcrypt0`
`d95e51a`	`src/doc/bootstrap: Generate cygwin.txt, cygwin-optional.txt`
`36f7b59`	`Merge branch 't/29106/ticket-29106' into t/29295/29106+ci`

Answer 16 · 2020-03-13T00:59:35.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`14f2967`	`Actually use libcrypt-devel`
`68314dc`	`Merge branch 't/29106/ticket-29106' into t/29295/29106+ci`

Answer 17 · 2020-03-13T00:59:35.000Z

Changed commit from 36f7b59 to 68314dc

Answer 18 · 2020-03-13T01:00:38.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`b263ac3`	`Run ci-cygwin.yml also on pull request`

Answer 19 · 2020-03-13T01:00:38.000Z

Changed commit from 68314dc to b263ac3

Answer 20 · 2020-03-13T08:30:34.000Z

comment:13

oh, right, it should have been https://cygwin.com/packages/summary/libcrypt-devel.html

Answer 21 · 2020-03-13T20:12:10.000Z

New commits:

`14f2967`	`Actually use libcrypt-devel`
`68314dc`	`Merge branch 't/29106/ticket-29106' into t/29295/29106+ci`
`b263ac3`	`Run ci-cygwin.yml also on pull request`

Answer 22 · 2020-03-19T20:16:38.000Z

Changed commit from b263ac3 to 85b3c3d

Answer 23 · 2020-03-19T20:16:38.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

`2034d61`	`save pwd`
`c4e44d1`	`fixup, prepare log artifact`
`193b699`	`fixup`
`b652a02`	`use cygpath`
`b8213bf`	`debug`
`e2f25de`	`do not fail fast`
`e56c8bd`	`Reset PATH so that only cygwin binaries are used`
`5fc4dd7`	`Simplify`
`488fb74`	`git config --global core.symlinks true`
`85b3c3d`	`Run ci-cygwin.yml also on pull request`

Answer 24 · 2020-03-19T20:16:59.000Z

Changed dependencies from #29106 to none

Answer 25 · 2020-03-19T20:17:09.000Z

comment:17

Rebased on 9.1.beta8

Answer 26 · 2020-03-22T18:34:08.000Z

Changed commit from 85b3c3d to 8f2991d

Answer 27 · 2020-03-22T18:34:08.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`d575cc1`	`ci-cygwin.yml: Run on pull requests only`
`8f2991d`	`.github/workflows/ci-cygwin.yml: Use sage-spkg -y -o`

Answer 28 · 2020-03-22T18:39:53.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

Answer 29 · 2020-03-22T18:39:53.000Z

Changed commit from 8f2991d to 85b3c3d

Answer 30 · 2020-03-24T16:46:13.000Z

comment:20

what is the point of having minimal here, as it takes too long?

Answer 31 · 2020-03-24T16:47:37.000Z

comment:21

Even if it times out, it provides valuable testing of the build process for the early packages.

Answer 32 · 2020-03-24T16:48:55.000Z

comment:22

But I'm working on the refinement of this workflow using several stages

Answer 33 · 2020-03-24T16:53:15.000Z

comment:23

ok

Answer 34 · 2020-03-24T16:53:15.000Z

Reviewer: Dima Pasechnik

Answer 35 · 2020-03-29T00:24:04.000Z

Changed branch from u/mkoeppe/29106+ci to 85b3c3d