sagemath/sage

Make dependencies of optional packages more detailed, no longer depend on all standard packages

mkoeppe opened this issue · 21 comments

#28095 (Add --enable-OPTIONALSPKG options to configure) made it possible to build Sage and a number of optional packages in one pass.

To improve opportunities for build parallelization, we should make dependencies of optional packages more detailed and no longer depend on all standard packages.

This will also make it faster to test builds from scratch to a specific optional package.

CC: @embray @dimpase @jhpalmieri

Component: build

Author: Matthias Koeppe

Branch: a5818c0

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/29426

comment:2

pushing these forward to 9.2

comment:3

Tests ran at https://github.com/mkoeppe/sage/actions/runs/77739151

Several optional packages that run their tests with the Sage doctester depend on ipywidgets when SAGE_CHECK=yes.
See for example https://github.com/mkoeppe/sage/runs/584777416?check_suite_focus=true:
sage_numerical_backends_coin, p_group_cohomology


New commits:

ebb07d1Optional/experimental packages: Remove order-only dependencies on all standard packages

Commit: ebb07d1

Branch pushed to git repo; I updated commit sha1. New commits:

d4773b8build/pkgs: Add ipywidgets as a dependency to packages using the sage doctester

Changed commit from ebb07d1 to d4773b8

Changed commit from d4773b8 to a5818c0

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6b20b84trac 26018: embray's work rebased to 9.1.rc0
8e6f694Optional/experimental packages: Remove order-only dependencies on all standard packages
a5818c0build/pkgs: Add ipywidgets as a dependency to packages using the sage doctester
comment:6

Rebased on top of #26018

Dependencies: #26018

Author: Matthias Koeppe

comment:8

New tests are running at https://github.com/mkoeppe/sage/actions/runs/81669565 (with #29341)

comment:9

This seems to work well. Needs review

kliem commented

Reviewer: Jonathan Kliem

kliem commented

Changed dependencies from #26018 to none

kliem commented
comment:10

LGTM.

comment:11

Thanks!

Changed commit from a5818c0 to none

comment:13

Follow-up: #30324

comment:14

+1 thanks