spkg-configure.m4 for flintqs
Closed this issue · 37 comments
This package only installs the QuadraticSieve executable, which needs to be in the PATH for qsieve() to work in Sage.
CC: @dimpase @embray @mkoeppe @kiwifb
Component: build: configure
Author: Michael Orlitzky
Branch/Commit: 5990654
Reviewer: Matthias Koeppe, Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/29430
Branch: u/mjo/ticket/29430
Needs distros/
Branch pushed to git repo; I updated commit sha1. New commits:
2b1e41b | Trac #29430: add distros/* information for flintqs. |
I added debian, fedora, and gentoo (I added the Gentoo package a few seconds before opening this ticket) based on repology.org results. Ubuntu and nix have packages too, but I don't see ubuntu.txt or nix.txt anywhere in the tree.
ubuntu uses debian.txt
Have you checked arch?
on conda it's flintqs too.
and on arch, cf https://www.archlinux.org/packages/community/x86_64/flintqs/
Fedora does not have flintqs
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
b343351 | Trac #29430: add distros/* information for flintqs. |
Force pushed a rename fedora -> conda. The arch.txt was already there (before I added the m4 file).
Reviewer: Matthias Koeppe, Dima Pasechnik
lgtm - but add author's name
Author: Michael Orlitzky
Let me run some tests first.
well, I did test on Debian. There is basically one version of this packages around.
Tests ran at https://github.com/mkoeppe/sage/actions/runs/66814284
Sorry, I'll have to add "mpir" to the DEPCHECK here. I didn't realize sage installed it in place of gmp with everything renamed mpir->gmp.
you need to check for BOTH gmp and mpir, not just one of them.
e.g.
SAGE_SPKG_CONFIGURE([givaro], [
m4_pushdef([SAGE_GIVARO_MINVER],["40101"])
SAGE_SPKG_DEPCHECK([gmp mpir], [
...
Thanks, I see that now. I was rather confused about how all these packages explicitly looking for libgmp in ./configure could use MPIR in sage. I'm halfway through a build test for a ppl spkg-configure but as soon as it finishes I'll fix this up.
Changed branch from u/mjo/ticket/29430 to public/packages/flintqs-config
lgtm
If this only installs an executable, I don't think we need any depcheck at all because there cannot be a library conflict.
The QuadraticSieve executable is the only thing used, and if it exists on the system, it should work fine.. does anyone philosophically object if --without-system-gmp (or mpir) is ignored for some packages?
Replying to @orlitzky:
does anyone philosophically object if
--without-system-gmp(or mpir) is ignored for some packages?
I don't think this is a concern.
Changed branch from public/packages/flintqs-config to u/mjo/ticket/29430
Changed branch from u/mjo/ticket/29430 to 5990654