Fix up "sage -i" for optional packages
mkoeppe opened this issue · 16 comments
Follow-up from #29113 ("Reimplement sage -i SPKG for optional/experimental packages as configure --enable-SPKG && make build").
This does not work in some situations as noted in #29418.
We fix it by reverting to the old installation method, but at least print some hints that explain the new configure arguments.
We will revisit this when other aspects of the Makefile have been cleaned up enough.
CC: @jhpalmieri @dimpase
Component: build
Author: Matthias Koeppe
Branch: 4de7648
Reviewer: John Palmieri
Issue created by migration from https://trac.sagemath.org/ticket/29481
Any progress here?
Description changed:
---
+++
@@ -2,3 +2,6 @@
This does not work in some situations as noted in #29418.
+We fix it by reverting to the old installation method, but at least print some hints that explain the new configure arguments.
+
+We will revisit this when other aspects of the Makefile have been cleaned up enough.Author: Matthias Koeppe
OK this should do the job for the next beta
This looks good to me.
Reviewer: John Palmieri
Thanks!
Changed branch from u/mkoeppe/fix_up__sage__i__for_optional_packages to 4de7648
Isn't a space missing between "passing" and "$ENABLE_ARGS" here?
+ echo >&2 "to be installed by passing$ENABLE_ARGS to ./configure"
$ENABLE_ARGS should contain a leading space: it's defined by the line
ENABLE_ARGS="$ENABLE_ARGS '--enable-$PKG'"
adding " '--enable-...'" (including a leading space) each time it's updated.