sagemath/sage

spkg-check.in: Remove messages that duplicate sage-spkg's messages

mkoeppe opened this issue · 8 comments

mkoeppe commented

build/bin/sage-spkg already does:

        echo "Running the test suite for $PKG_NAME..."

and

            if [ "$SAGE_CHECK" = "warn" ]; then
                error_msg "Warning: Error testing package $PKG_NAME (ignored)" "make check"
            else
                error_msg "Error testing package $PKG_NAME" "make check"
                exit 1
            fi

So we remove the messages printed by individual spkg-check.in.

Depends on #29492

CC: @jhpalmieri @embray @dimpase

Component: build

Author: Matthias Koeppe

Branch/Commit: 9b213a4

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/29510

sagetrac-git commented

Branch pushed to git repo; I updated commit sha1. New commits:

9b213a4build/bin/sage-spkg: Add message when test suite passed
mkoeppe commented

Author: Matthias Koeppe

jhpalmieri commented

Reviewer: John Palmieri

jhpalmieri commented
comment:5

Looks okay to me.

mkoeppe commented
comment:6

Thanks!