Make Docker images generated by GitHub CI workflows available; minor CI fixes

Question

Make Docker images generated by GitHub CI workflows available; minor CI fixes

mkoeppe opened this issue 6 years ago · 42 comments

They are already tagged with meaningful names and just need to be pushed to a registry.

Now we push them to the registry provided by GitHub.
Example: https://github.com/mkoeppe/sage/runs/604103405 created https://github.com/mkoeppe/sage/packages/193111

Depends on #29341
Depends on #29534

CC: @kliem @vbraun @dimpase @embray @saraedum @slel

Component: porting

Keywords: ci, ContinuousIntegration

Author: Matthias Koeppe

Branch/Commit: 163562d

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29530

Answer 1 · 2020-04-18T20:20:33.000Z

Changed keywords from none to ci

Answer 2 · 2020-04-19T06:31:41.000Z

Description changed:

--- 
+++ 
@@ -1,3 +1,7 @@
+They are already tagged with meaningful names and just need to be pushed to a registry.
+
+Also the CI workflows should be run `on: push: tags:` (https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestbranchestags), not just `on: pull_requests`
+
 https://www.docker.com/blog/first-docker-github-action-is-here/
 
 https://github.com/actions/starter-workflows/blob/master/ci/docker-publish.yml

Answer 3 · 2020-04-19T07:53:47.000Z

comment:3

will it be possible to pull an image for letting cal inspection and debugging? cool.
(currently building a fedora 28 image locally...)

Answer 4 · 2020-04-19T22:25:26.000Z

Dependencies: #29341

Answer 5 · 2020-04-20T01:35:55.000Z

Changed keywords from ci to ci, ContinuousIntegration

Answer 6 · 2020-04-20T01:42:24.000Z

Changed dependencies from #29341 to #29341, #29534

Answer 7 · 2020-04-20T01:42:24.000Z

Description changed:

--- 
+++ 
@@ -1,6 +1,6 @@
 They are already tagged with meaningful names and just need to be pushed to a registry.
 
-Also the CI workflows should be run `on: push: tags:` (https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestbranchestags), not just `on: pull_requests`
+Also the CI workflows should be run `on: push: tags:` (https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestbranchestags), not just `on: pull_requests`; that's #29534.
 
 https://www.docker.com/blog/first-docker-github-action-is-here/

Answer 8 · 2020-04-20T01:43:12.000Z

comment:7

Replying to @dimpase:

will it be possible to pull an image for ... inspection and debugging?

Yes, that's the idea

Answer 9 · 2020-04-21T05:03:21.000Z

Branch: u/mkoeppe/make_docker_images_generated_by_github_ci_workflows_available

Answer 10 · 2020-04-21T05:33:45.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`e506503`	`Add documentation`
`d6b64ba`	`tox-optional.yml: Push the docker images`

Answer 11 · 2020-04-21T05:33:45.000Z

Commit: d6b64ba

Answer 12 · 2020-04-21T05:38:16.000Z

Description changed:

--- 
+++ 
@@ -1,9 +1,4 @@
-They are already tagged with meaningful names and just need to be pushed to a registry.
+They are already tagged with meaningful names and just need to be pushed to a registry. 
 
-Also the CI workflows should be run `on: push: tags:` (https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestbranchestags), not just `on: pull_requests`; that's #29534.
-
-https://www.docker.com/blog/first-docker-github-action-is-here/
-
-https://github.com/actions/starter-workflows/blob/master/ci/docker-publish.yml
-
-
+Now we push them to the registry provided by [GitHub](../wiki/GitHub).
+Example: https://github.com/mkoeppe/sage/runs/604103405 created https://github.com/mkoeppe/sage/packages/193111

Answer 13 · 2020-04-21T05:38:16.000Z

Author: Matthias Koeppe

Answer 14 · 2020-04-21T05:42:54.000Z

Changed commit from d6b64ba to 06a9c39

Answer 15 · 2020-04-21T05:42:54.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`06a9c39`	`fixup doc`

Answer 16 · 2020-04-21T23:56:24.000Z

Changed commit from 06a9c39 to 02f86f6

Answer 17 · 2020-04-21T23:56:24.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`02f86f6`	`tox*.yml: First try secrets.DOCKER_PKG_GITHUB_TOKEN, then secrets.GITHUB_TOKEN; ignore errors`

Answer 18 · 2020-04-23T02:07:01.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`00a82b0`	`Merge tag '9.1.rc1' into t/29530/make_docker_images_generated_by_github_ci_workflows_available`
`807c2bd`	`Fix spelling of --downloadonly`
`bd687c9`	`Merge branch 't/29403/ci_cygwin_yml__multi_stage_build' into t/29341/optional-test-9.1.rc0`
`784abe8`	`ci-cygwin.yml: SAGE_FAT_BINARY=yes`
`eeadb9d`	`.github/workflows/ci-cygwin.yml: Test more optional packages`
`316c5f6`	`Fixup`
`37c2186`	`Merge branch 't/29341/optional-test-9.1.rc0' into t/29530/make_docker_images_generated_by_github_ci_workflows_available`

Answer 19 · 2020-04-23T02:07:01.000Z

Changed commit from 02f86f6 to 37c2186

Answer 20 · 2020-04-23T03:22:02.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`87210e9`	`.github/workflows/ci-cygwin.yml: Rebalance stages`
`0d886cc`	`build/pkgs/pari_nftables/distros/arch.txt: Remove (package does not exist)`

Answer 21 · 2020-04-23T03:22:02.000Z

Changed commit from 37c2186 to 0d886cc

Answer 22 · 2020-04-23T16:59:45.000Z

Changed commit from 0d886cc to 652787b

Answer 23 · 2020-04-23T16:59:45.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`652787b`	`.github/workflows/tox*.yml: Make copying logs from containers more robust`

Answer 24 · 2020-04-24T14:14:47.000Z

comment:17

copying logs needs more work, e.g. https://github.com/mkoeppe/sage/runs/612694530?check_suite_focus=true displays no logs

Answer 25 · 2020-04-25T00:20:10.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`2b9f531`	`local-{conda,homebrew}-maximal: Take packages from -standard`

Answer 26 · 2020-04-25T00:20:10.000Z

Changed commit from 652787b to 2b9f531

Answer 27 · 2020-04-25T01:52:15.000Z

Changed commit from 2b9f531 to 88b5aa6

Answer 28 · 2020-04-25T01:52:15.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`88b5aa6`	`tox.ini: Commit a failed build container so that logs are copied from it`

Answer 29 · 2020-04-25T01:53:26.000Z

Changed commit from 88b5aa6 to f8c6e7a

Answer 30 · 2020-04-25T01:53:26.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`f8c6e7a`	`tox.ini: Commit a failed build container so that logs are copied from it`

Answer 31 · 2020-04-25T03:29:23.000Z

Changed commit from f8c6e7a to 4f4fe60

Answer 32 · 2020-04-25T03:29:23.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`5c8e685`	`tox-optional.yml: Fix likewise`
`4f4fe60`	`ci-cygwin.yml: Split the file so that unrelated stages do not wait`

Answer 33 · 2020-04-25T17:47:45.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`27c63f1`	`Improve docker login instructions`

Answer 34 · 2020-04-25T17:47:45.000Z

Changed commit from 4f4fe60 to 27c63f1

Answer 35 · 2020-04-25T22:01:37.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`dbf461d`	`Merge tag '9.1.rc2' into t/29530/make_docker_images_generated_by_github_ci_workflows_available`

Answer 36 · 2020-04-25T22:01:37.000Z

Changed commit from 27c63f1 to dbf461d

Answer 37 · 2020-04-25T22:07:01.000Z

Changed commit from dbf461d to 163562d

Answer 38 · 2020-04-25T22:07:01.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`163562d`	`Rename cygwin workflows`

Answer 39 · 2020-04-26T02:37:18.000Z

comment:26

OK, this looks nice now. I have tested just one docker image, but I trust this should be fine in general.

Answer 40 · 2020-04-26T02:37:18.000Z

Reviewer: Dima Pasechnik

Answer 41 · 2020-04-26T02:42:29.000Z

comment:27

Thank you!

Answer 42 · 2020-05-02T21:58:21.000Z

Changed branch from u/mkoeppe/make_docker_images_generated_by_github_ci_workflows_available to 163562d