Move Extension options from src/module_list.py to "distutils:" directives in the individual files (part 2 - OptionalExtensions)
mkoeppe opened this issue · 21 comments
Follow-up from #29706.
In this part, we take care of all OptionalExtensions except for
CC: @kiwifb @dimpase @jhpalmieri @tscrim @kliem @roed314 @videlec @vbraun
Component: refactoring
Keywords: sd109
Author: Matthias Koeppe
Branch/Commit: 2821934
Reviewer: Jonathan Kliem
Issue created by migration from https://trac.sagemath.org/ticket/29720
New commits:
69004cd | src/sage: Move OptionalExtension options from src/module_list.py to distutils directives |
Changed keywords from none to sd109
Description changed:
---
+++
@@ -1,4 +1,5 @@
Follow-up from #29706.
-In this part, we take care of all `OptionalExtension`s.
+In this part, we take care of all `OptionalExtension`s except for tdlib, which is taken care of in #28925.
+Description changed:
---
+++
@@ -1,5 +1,8 @@
Follow-up from #29706.
-In this part, we take care of all `OptionalExtension`s except for tdlib, which is taken care of in #28925.
+In this part, we take care of all `OptionalExtension`s except for
+- `tdlib`, which is taken care of in #28925;
+- `coxeter` (#29721)
+Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
9805a19 | src/sage: Move OptionalExtension options from src/module_list.py to distutils directives |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
401a864 | src/sage: Move OptionalExtension options (except tdlib) from src/module_list.py to distutils directives |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
bfd9fed | src/sage: Move OptionalExtension options (except tdlib, coxeter) from src/module_list.py to distutils directives |
fes does not really exist (it was an old-style experimental package that was never converted to new-style), but it's not the job of this ticket to remove the corresponding extension.
Author: Matthias Koeppe
Branch pushed to git repo; I updated commit sha1. New commits:
2821934 | Fix sage_setup directives: Use distribution, not package |
Description changed:
---
+++
@@ -1,7 +1,7 @@
Follow-up from #29706.
In this part, we take care of all `OptionalExtension`s except for
-- `tdlib`, which is taken care of in #28925;
+- `tdlib`, which is taken care of in #29701;
- `coxeter` (#29721)
LGTM.
Reviewer: Jonathan Kliem
Thanks!