Remove packages that handle backporting from Python 3 to Python 2

Question

Remove packages that handle backporting from Python 3 to Python 2

jhpalmieri opened this issue 5 years ago · 55 comments

jhpalmieri commented 5 years ago

Remove

backports_abc
backports_functools_lru_cache
backports_shutil_get_terminal_size
backports_ssl_match_hostname
configparser
enum34
functools32
future
ipaddress
pathlib2
singledispatch
subprocess32
typing

Let's also remove sagenb, since it doesn't build with Python 3. That lets us remove

flask
flask_autoindex
flask_babel
flask_oldsessions
flask_openid
flask_silk
sagenb
twisted (it may be used by terminado when it is present, but terminado seems to function fine without it)
werkzeug

Component: packages: standard

Keywords: sd109

Author: John Palmieri

Branch/Commit: 0578937

Reviewer: Dima Pasechnik, Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/29754

Answer 1 · 2020-05-28T20:34:31.000Z

comment:1

sagenb should go, too, it doesn't work in py3.

Answer 2 · 2020-05-28T20:37:22.000Z

Description changed:

--- 
+++ 
@@ -1,4 +1,8 @@
 Remove
+
+- python2
+
+and
 
 - backports_abc
 - backports_functools_lru_cache

Answer 3 · 2020-05-28T20:48:35.000Z

Description changed:

--- 
+++ 
@@ -20,7 +20,7 @@
 
 Also remove the use of `six` in the build process. (There are still many uses of `six` in the Sage library, and also the package `traitlets` uses it, so we cannot delete `six` now.)
 
-Should we also remove `sagenb`? That would let us remove
+Let's also remove `sagenb`, since it doesn't build with Python 3. That lets us remove
 
 - flask
 - flask_autoindex
@@ -32,4 +32,3 @@
 - twisted ? (it may be used by terminado when it is present, but terminado may function fine without it)
 - werkzeug
 
-If the sagenb removal is a good idea, it could also be done on a separate ticket.

Answer 4 · 2020-05-28T21:51:39.000Z

Dependencies: #29752

Answer 5 · 2020-05-28T21:53:35.000Z

Branch: u/jhpalmieri/werkzeug-optional

Answer 6 · 2020-05-28T21:53:51.000Z

Commit: 27b3d91

Answer 7 · 2020-05-28T21:53:51.000Z

New commits:

`56444d6`	`trac 29752: convert werkzeug from standard to optional`
`27b3d91`	`trac 29754: remove packages backported Python 3 components to Python 2.`

Answer 8 · 2020-05-28T22:34:47.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`ddca85a`	`trac 29752: convert werkzeug from standard to optional`

Answer 9 · 2020-05-28T22:34:47.000Z

Changed commit from 27b3d91 to ddca85a

Answer 10 · 2020-05-28T22:37:54.000Z

Changed commit from ddca85a to 27b3d91

Answer 11 · 2020-05-28T22:37:54.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`56444d6`	`trac 29752: convert werkzeug from standard to optional`
`27b3d91`	`trac 29754: remove packages backported Python 3 components to Python 2.`

Answer 12 · 2020-05-28T22:40:40.000Z

Changed commit from 27b3d91 to 9385b73

Answer 13 · 2020-05-28T22:40:40.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`ddca85a`	`trac 29752: convert werkzeug from standard to optional`
`9385b73`	`trac 29754: remove packages backported Python 3 components to Python`

Answer 14 · 2020-05-28T22:41:28.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

Answer 15 · 2020-05-28T22:41:28.000Z

Changed commit from 9385b73 to ddca85a

Answer 16 · 2020-05-28T22:48:51.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`e1a0c8c`	`trac 29752: convert werkzeug from standard to optional`
`406a030`	`trac 29754: remove packages backported Python 3 components to Python`

Answer 17 · 2020-05-28T22:48:51.000Z

Changed commit from ddca85a to 406a030

Answer 18 · 2020-05-28T22:52:39.000Z

comment:12

I have to test my new branch. I'll set it back to "needs review" when that's done.

Answer 19 · 2020-05-28T22:53:30.000Z

Changed branch from u/jhpalmieri/werkzeug-optional to none

Answer 20 · 2020-05-28T22:53:30.000Z

Changed dependencies from #29752 to none

Answer 21 · 2020-05-28T22:53:30.000Z

Changed commit from 406a030 to none

Answer 22 · 2020-05-29T01:46:04.000Z

Branch: u/jhpalmieri/no-py2-backports

Answer 23 · 2020-05-29T01:46:23.000Z

Commit: 2903b22

Answer 24 · 2020-05-29T01:46:23.000Z

comment:15

Okay, ready for review.

New commits:

`2903b22`	`trac 29754: remove packages which backport Python 3 components:`

Answer 25 · 2020-05-29T22:26:08.000Z

comment:16

lgtm

Answer 26 · 2020-05-29T22:26:08.000Z

Reviewer: Dima Pasechnik

Answer 27 · 2020-05-29T23:06:56.000Z

comment:17

Thanks, but as you and Matthias noted on another ticket, this needs rebasing. I'll work on that.

Answer 28 · 2020-05-30T04:13:54.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

`32bb2fe`	`Merge tag '9.1.rc3' into t/29633/src_doc_bootstrap__generate_list_of_packages__with_links_to_documentation__for_ref_manual_from_build_pkgs`
`7555ba6`	`Merge branch 't/29633/src_doc_bootstrap__generate_list_of_packages__with_links_to_documentation__for_ref_manual_from_build_pkgs' into t/29669/for_sage_9_2__remove_python_2_support_from_the_build_system`
`520078a`	`build/pkgs/python2: Remove`
`f712bb5`	`configure.ac: Remove option --with-python=2`
`96a5e76`	`Remove python2 from tox and [GitHub](../wiki/GitHub) CI scripts`
`ea7df3e`	`configure.ac: Remove message 'Checking for Python version to install...'`
`ff41817`	`configure.ac: Warn on 'configure --with-python=3.x'`
`378bf54`	`Merge branch 't/29669/for_sage_9_2__remove_python_2_support_from_the_build_system' into t/29757/_github_workflows_tox_gcc_spkg_yml__remove_python2`
`225f730`	`.github/workflows/tox-gcc_spkg.yml: Remove python2`
`c182f48`	`trac 29754: remove packages backporting Python 3 components to Python 2.`

Answer 29 · 2020-05-30T04:13:54.000Z

Changed commit from 2903b22 to c182f48

Answer 30 · 2020-05-30T04:14:54.000Z

Description changed:

--- 
+++ 
@@ -1,8 +1,4 @@
 Remove
-
-- python2
-
-and
 
 - backports_abc
 - backports_functools_lru_cache
@@ -18,8 +14,6 @@
 - subprocess32
 - typing
 
-Also remove the use of `six` in the build process. (There are still many uses of `six` in the Sage library, and also the package `traitlets` uses it, so we cannot delete `six` now.)
-
 Let's also remove `sagenb`, since it doesn't build with Python 3. That lets us remove
 
 - flask
@@ -29,6 +23,6 @@
 - flask_openid
 - flask_silk
 - sagenb
-- twisted ? (it may be used by terminado when it is present, but terminado may function fine without it)
+- twisted (it may be used by terminado when it is present, but terminado seems to function fine without it)
 - werkzeug

Answer 31 · 2020-05-30T04:14:54.000Z

Dependencies: #29757

Answer 32 · 2020-05-30T04:14:54.000Z

comment:19

Rebased to #29757.

Answer 33 · 2020-06-06T17:06:40.000Z

comment:20

Can zope_interface also be removed?

$ grep zope_interface build/pkgs/*/dependencies
build/pkgs/twisted/dependencies:$(PYTHON) | $(PYTHON_TOOLCHAIN) zope_interface

Answer 34 · 2020-06-06T17:26:01.000Z

comment:21

I tested this meanwhile, it works. Most probably zope_interface may go too, it only is mentioned in doctests (and as a dependence of removed here twisted)

Answer 35 · 2020-06-06T17:42:10.000Z

comment:22

If this version here works, let's get this ticket in, and do the zope_interface removal on a follow-up ticket.

Answer 36 · 2020-06-06T17:42:52.000Z

comment:23

This could happen on #29803.

Answer 37 · 2020-06-06T18:19:44.000Z

comment:24

Removal of zope_interface is now done on #29803, actually I changed it to a dummy script package there so that #29803 is independent of this one here.

Answer 38 · 2020-06-06T20:54:32.000Z

comment:25

lgtm

Answer 39 · 2020-06-06T21:27:44.000Z

comment:26

Conflicts with #29745

Answer 40 · 2020-06-06T21:27:56.000Z

Changed branch from u/jhpalmieri/no-py2-backports to u/mkoeppe/no-py2-backports

Answer 41 · 2020-06-06T21:28:17.000Z

Changed reviewer from Dima Pasechnik to Dima Pasechnik, Matthias Koeppe

Answer 42 · 2020-06-06T21:28:17.000Z

New commits:

`4672d55`	`trac 29633: fixes for PDF docbuilding`
`2ee9bef`	`Merge tag '9.1' into t/29633/src_doc_bootstrap__generate_list_of_packages__with_links_to_documentation__for_ref_manual_from_build_pkgs`
`9c7ea5f`	`trac 29633: fix SQLite doctests in cmdline.py`
`8baef11`	`trac 29745: clean up various SPKG.rst files`
`c559f26`	`Merge branch 't/29669/for_sage_9_2__remove_python_2_support_from_the_build_system' into t/29745/cleanup-spkg-rst-files`
`05a6937`	`Merge commit 'c559f26caf56378c8c4a5652f577986b4f5d431c' of git://trac.sagemath.org/sage into t/29754/no-py2-backports`

Answer 43 · 2020-06-06T21:28:17.000Z

Changed commit from c182f48 to 05a6937

Answer 44 · 2020-06-07T21:07:53.000Z

comment:29

Follow-up: #29823

Answer 45 · 2020-06-16T20:42:35.000Z

comment:30

Another follow-up: #29878

Answer 46 · 2020-06-17T23:08:01.000Z

comment:31

And another: #29885 (remove "sage -n sagenb" as an advertised option, and strip the SageNB code from the sage-notebook script).

Answer 47 · 2020-06-24T23:39:43.000Z

comment:32

Merge conflict

Answer 48 · 2020-06-25T00:02:34.000Z

Changed commit from 05a6937 to cc61541

Answer 49 · 2020-06-25T00:02:34.000Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`8387b7b`	`add forgotten doctest fix.`
`2ddcd31`	`change upstream_url to a (hopefully) more stable and easy to decipher address for sphinx packages`
`649289e`	`move sphinx packages from pip to PYTHON_TOOLCHAIN`
`e5415da`	`trac 28856: fix apostrophes in wikipedia links`
`b9d44e3`	`Merge branch 'ticket-28000' into sphinx3`
`8f66113`	`Minor upgdrade to Sphinx 3.0.3`
`321e2bf`	`Bump to 3.0.4`
`ee7195c`	`Merge branch 'matplotlib3.2.1' into sphinx3`
`bd99462`	`Merge branch 'develop' into sphinx3`
`cc61541`	`Merge commit 'bd99462f6f89757b9b1674fbeb55743ce7f6fab6' of git://trac.sagemath.org/sage into t/29754/no-py2-backports`

Answer 50 · 2020-06-25T00:03:27.000Z

Changed dependencies from #29757 to #29757, #28856

Answer 51 · 2020-06-26T16:33:13.000Z

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

`0578937`	`Merge tag '9.2.beta2' into t/29754/no-py2-backports`

Answer 52 · 2020-06-26T16:33:13.000Z

Changed commit from cc61541 to 0578937

Answer 53 · 2020-06-26T16:33:36.000Z

Changed dependencies from #29757, #28856 to none

Answer 54 · 2020-06-26T16:33:36.000Z

comment:36

merged in the latest beta

Answer 55 · 2020-06-27T09:26:40.000Z

Changed branch from u/mkoeppe/no-py2-backports to 0578937