sagemath/sage

Move Extension options from src/module_list.py to "distutils:" directives in the individual files (part 6: last)

Closed this issue · 18 comments

Follow-up from #29706.

It takes care of all remaining extensions.

Depends on #29706

CC: @kliem

Component: refactoring

Author: Matthias Koeppe

Branch: 802356a

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/29791

Author: Matthias Koeppe

Last 10 new commits:

70901easrc/sage/env.py (cython_aliases): Update doctest
eed920esrc/sage/tests: Move Extension options from src/module_list.py to distutils directives
0d25d1dsrc/sage/structure: Move Extension options from src/module_list.py to distutils directives
808f46asrc/sage/stats: Move Extension options from src/module_list.py to distutils directives
10f7542src/sage/schemes: Move Extension options from src/module_list.py to distutils directives
5867c05src/sage/modular/pollack_stevens/dist.pyx: Add missing distutils directives
c536daaRemove self-listing in distutils sources directive
9dc7022Merge branch 't/29706/move_extension_options_from_src_module_list_py_to__distutils___directives_in_the_individual_files' into t/29791/move_extension_options_from_src_module_list_py_to__distutils___directives_in_the_individual_files__part_6__last_
96b99c8src/module_list.py: Move options for Extensions in sage.matrix to distutils directives
2355836src/module_list.py: Move remaining options for Extensions in sage.libs, sage.rings to distutils directives

Commit: 2355836

Description changed:

--- 
+++ 
@@ -1 +1,5 @@
-Follow-up from #29706
+Follow-up from #29706.
+
+It takes care of all remaining extensions.
+
+

Dependencies: #29706

Changed commit from 2355836 to 6421e2c

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f78b06dsrc/module_list.py: Move options for Extensions in sage.libs to distutils directives
1b0e29dsrc/module_list.py: Move options for Extensions in sage.matrix to distutils directives
6421e2csrc/module_list.py: Move remaining options for Extensions in sage.libs, sage.rings to distutils directives

Changed commit from 6421e2c to 802356a

Branch pushed to git repo; I updated commit sha1. New commits:

b1b3787sage.env.cython_aliases: Fix for systems without zlib pc
802356aMerge branch 't/29706/move_extension_options_from_src_module_list_py_to__distutils___directives_in_the_individual_files' into t/29791/move_extension_options_from_src_module_list_py_to__distutils___directives_in_the_individual_files__part_6__last_
kliem commented
comment:6

What about

+              depends = [SAGE_INC + "/polybori/" + hd + ".h" for hd in ["polybori", "config"]]),

Is that going to stay there? Is this being removed in a different ticket?

comment:7

Ah right, that's a loose end...

kliem commented

Reviewer: Jonathan Kliem

kliem commented
comment:8

LGTM.

comment:9

Thanks!

Changed commit from 802356a to none

comment:11

Is there a follow-up ticket? E.g. the polybori thing in comment:6 is still not fixed.