Clean-up for src/bin/sage-env, move src/bin/sage-clone-source, src/bin/sage-sdist to build/bin

Question

Clean-up for src/bin/sage-env, move src/bin/sage-clone-source, src/bin/sage-sdist to build/bin

Closed this issue 5 years ago · 27 comments

mkoeppe commented 5 years ago

We remove some unused environment variables from the sage runtime environment.

Part of Meta-ticket #21707: Split sage-env into 5 to clean up sage configuration

Depends on #21559
Depends on #29929
Depends on #30088

CC: @orlitzky @kiwifb @antonio-rojas @vbraun

Component: build

Author: Matthias Koeppe

Branch/Commit: 7c91fb4

Reviewer: John Palmieri, François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/29825

Answer 1 · 2020-06-08T06:31:47.000Z

Branch: u/mkoeppe/clean_up_for_src_bin_sage_env

Answer 2 · 2020-06-08T06:35:36.000Z

Commit: 20b81cc

Answer 3 · 2020-06-08T06:35:36.000Z

Description changed:

--- 
+++ 
@@ -1 +1,2 @@
+We remove some unused environment variables from the sage runtime environment.

Answer 4 · 2020-06-08T06:35:36.000Z

Author: Matthias Koeppe

Answer 5 · 2020-06-08T06:35:36.000Z

New commits:

`a61ce1e`	`src/bin/sage-env-config.in: Do not export CONFIGURED_CC etc. and SAGE_PKG_CONFIG_PATH; only used in sage-env`
`f0e37ad`	`build/make/install: Move SAGE_SPKG_SCRIPTS here from src/bin/sage-env; only used during build`
`20b81cc`	`src/bin/sage-env: Do not set SAGE_PKGCONFIG; only use in build/ and already set in build/make/install`

Answer 6 · 2020-06-12T21:10:15.000Z

Description changed:

--- 
+++ 
@@ -1,2 +1,3 @@
 We remove some unused environment variables from the sage runtime environment.
 
+Part of Meta-ticket #21707: Split sage-env into 5 to clean up sage configuration

Answer 7 · 2020-06-16T20:49:16.000Z

Reviewer: John Palmieri

Answer 8 · 2020-06-16T20:49:16.000Z

comment:6

Looks okay to me.

Answer 9 · 2020-06-16T23:09:19.000Z

comment:7

Thanks!

Answer 10 · 2020-06-27T09:25:42.000Z

Changed branch from u/mkoeppe/clean_up_for_src_bin_sage_env to 20b81cc

Answer 11 · 2020-07-04T15:51:26.000Z

Changed commit from 20b81cc to none

Answer 12 · 2020-07-04T15:51:26.000Z

comment:9

This breaks sage -sdist which is part of the release process:

rm -f /openblas.pc
(echo "Name: openblas"; echo "Description: OpenBLAS"; echo "Version: 0.3"; echo "Libs: -lopenblas ") > "/openblas.pc"
/bin/sh: /openblas.pc: Permission denied
make[1]: *** [Makefile:59: /openblas.pc] Error 1
make[1]: Leaving directory '/home/release/Sage/build/make'
make: *** [Makefile:1766: download-for-sdist] Error 2

Answer 13 · 2020-07-04T19:00:19.000Z

Dependencies: #21559

Answer 14 · 2020-07-05T21:25:32.000Z

Changed dependencies from #21559 to #21559, #29929

Answer 15 · 2020-07-15T23:23:59.000Z

Changed dependencies from #21559, #29929 to #21559, #29929, #30088

Answer 16 · 2020-07-16T00:20:51.000Z

Changed branch from 20b81cc to u/mkoeppe/20b81cc091936228d8c1355e98a96c6e2bf95b09

Answer 17 · 2020-07-16T00:37:37.000Z

Commit: c1eb3ea

Answer 18 · 2020-07-16T00:37:37.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`46ac26e`	`Move src/bin/sage-clone-source, src/bin/sage-sdist to build/bin`
`c1eb3ea`	`Makefile: Make dist a phony target`

Answer 19 · 2020-07-27T00:57:03.000Z

comment:18

LGTM. This is all fairly minor spring cleaning. Apart from the dist stuff which was annoying.

Answer 20 · 2020-07-27T00:57:03.000Z

Changed reviewer from John Palmieri to John Palmieri, François Bissey

Answer 21 · 2020-07-27T00:58:46.000Z

comment:19

Thanks.

Answer 22 · 2020-07-30T20:45:43.000Z

comment:20

[sagelib-9.2.beta6] copying bin/sage-cachegrind -> build/scripts-3.7
[sagelib-9.2.beta6] copying bin/sage-callgrind -> build/scripts-3.7
[sagelib-9.2.beta6] copying bin/sage-massif -> build/scripts-3.7
[sagelib-9.2.beta6] copying bin/sage-omega -> build/scripts-3.7
[sagelib-9.2.beta6] copying bin/sage-valgrind -> build/scripts-3.7
[sagelib-9.2.beta6] copying bin/sage-version.sh -> build/scripts-3.7
[sagelib-9.2.beta6] copying and adjusting bin/sage-cleaner -> build/scripts-3.7
[sagelib-9.2.beta6] copying and adjusting bin/sage-list-packages -> build/scripts-3.7
[sagelib-9.2.beta6] error: file '/home/release/Sage/src/bin/sage-clone-source' does not exist
[sagelib-9.2.beta6] 
[sagelib-9.2.beta6] real        5m25.685s
[sagelib-9.2.beta6] user        49m14.730s
[sagelib-9.2.beta6] sys 1m10.018s
make[4]: *** [Makefile:2090: sagelib-no-deps] Error 1
make[4]: Leaving directory '/home/release/Sage/build/make'
make[3]: *** [Makefile:2090: /home/release/Sage/local/var/lib/sage/installed/sagelib-9.2.beta6] Error 2
make[3]: Leaving directory '/home/release/Sage/build/make'
make[2]: *** [Makefile:1701: all-start] Error 2
make[2]: Leaving directory '/home/release/Sage/build/make'

Answer 23 · 2020-07-30T20:53:58.000Z

Changed commit from c1eb3ea to 7c91fb4

Answer 24 · 2020-07-30T20:53:58.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`7c91fb4`	`src/setup.py: Remove sage-clone-source, sage-sdist from list of installed sagelib scripts`

Answer 25 · 2020-07-30T21:07:45.000Z

comment:23

Now, that's something I should have checked. All good now as far as I can see it.

Answer 26 · 2020-07-30T21:21:58.000Z

comment:24

Thanks!

Answer 27 · 2020-08-07T19:07:35.000Z

Changed branch from u/mkoeppe/20b81cc091936228d8c1355e98a96c6e2bf95b09 to 7c91fb4