sage.categories.pushout.type_to_parent: Reimplement using py_scalar_parent

Question

sage.categories.pushout.type_to_parent: Reimplement using py_scalar_parent

Closed this issue 5 years ago · 9 comments

mkoeppe commented 5 years ago

type_to_parent seems to be a less complete implementation of py_scalar_parent.

The change on this ticket helps get rid some explicit imports from sage.rings.

CC: @tscrim @mezzarobba

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 4b37cc6

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29880

Answer 1 · 2020-06-17T02:24:46.000Z

Branch: u/mkoeppe/sage_categories_pushout_type_to_parent__reimplement_using_py_scalar_parent

Answer 2 · 2020-06-17T02:26:08.000Z

Description changed:

--- 
+++ 
@@ -1,2 +1,3 @@
 `type_to_parent` seems to be a less complete implementation of `py_scalar_parent`.
 
+The change on this ticket helps get rid some explicit imports from `sage.rings`.

Answer 3 · 2020-06-17T02:26:08.000Z

New commits:

`4b37cc6`	`sage.categories.pushout.type_to_parent: Reimplement using py_scalar_parent`

Answer 4 · 2020-06-17T02:26:08.000Z

Author: Matthias Koeppe

Answer 5 · 2020-06-17T02:26:08.000Z

Commit: 4b37cc6

Answer 6 · 2020-06-17T02:32:11.000Z

Reviewer: Travis Scrimshaw

Answer 7 · 2020-06-17T02:32:11.000Z

comment:3

A good example of needing to DRY things out. ahem

Green patchbot => positive review.

Answer 8 · 2020-06-17T06:06:45.000Z

comment:4

Thanks!

Answer 9 · 2020-07-02T21:30:00.000Z

Changed branch from u/mkoeppe/sage_categories_pushout_type_to_parent__reimplement_using_py_scalar_parent to 4b37cc6