sagemath/sage

Add tutorial-like docstring material on RecursivelyEnumeratedSet

Closed this issue · 17 comments

mkoeppe commented

... from a forgotten branch on #16351 ...

CC: @hivert @tscrim @seblabbe @nthiery @slel

Component: combinatorics

Author: Florent Hivert, Sébastien Labbé

Branch/Commit: 90dc326

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29882

mkoeppe commented

Commit: 1bf8c97

seblabbe commented

Author: Florent Hivert, Sébastien Labbé

seblabbe commented

Changed commit from 1bf8c97 to 8b9869f

seblabbe commented
comment:3

I just did few modifications to properly include Florent's example into the doc.

New commits:

cb48f33Revert "Removed TODO in doc"
8b9869f29882: including the two examples provided by Florent Hivert into docstring
seblabbe commented
comment:4

Note that I rebased old Florent Hivert's commit on top of 9.2.beta1 (new commit hash is cb48f33).

sagetrac-git commented

Branch pushed to git repo; I updated commit sha1. New commits:

46cce8fMerge branch 'public/29882' of git://trac.sagemath.org/sage into public/29882
b44aac2Some reviewer changes.
sagetrac-git commented

Changed commit from 8b9869f to b44aac2

tscrim commented
comment:6

I made a few small changes to try and improve the exposition. If my changes are good, then positive review.

tscrim commented

Reviewer: Travis Scrimshaw

mwageringel commented
comment:7

There are a few lines which are syntax errors in Python 3:

    def children((lst, st)):

        post_process = lambda (l, s): tuple(l) if not s else None,
sagetrac-git commented

Branch pushed to git repo; I updated commit sha1. New commits:

0a8c6d8Merge branch 'public/29882' of trac.sagemath.org:/sage into 29882
90dc32629882: adapted examples to Python3 syntax
sagetrac-git commented

Changed commit from b44aac2 to 90dc326

seblabbe commented
comment:9

Needs review.

tscrim commented
comment:10

LGTM.

vbraun commented

Changed branch from public/29882 to 90dc326