sage.structure: Remove some module-level imports
Closed this issue · 17 comments
Depends on #29892
Depends on #29873
CC: @tscrim
Component: refactoring
Author: Matthias Koeppe
Branch/Commit: a75ea75
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/29883
New commits:
5fe64b1 | sage.structure.factorization: Make import of sage.rings.integer.Integer local to methods |
eb841de | sage.structure.sequence: Make import of sage.misc.latex local to the latex method |
e45b305 | sage.structure.factorization: Make import of sage.misc.misc_c.prod local to methods |
d353497 | sage.structure.formal_sum, .parent_gens: Fixup: Remove imports |
These are all okay with me. I am very slightly worried about the Factorization.__pow__, but I doubt anyone is calling that in a sufficiently tight loop for the import to affect that, unless you are calling x^0 or x^1 a lot with x being a factorization. So it is probably fine.
Green patchbot => positive review.
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
a5453bf | Fixup: Add src/sage/misc/call.py |
64c5701 | lazy_import from sage.misc.call with deprecation |
65414f7 | Fix imports and one deprecation warning |
b9314d4 | sage.misc.call: Add standard header information, add to reference manual |
6024ffd | src/sage/misc/call.py: register_unpickle_override for call_method |
ab4e0fd | Move sage.misc.misc.coeff_repr, repr_lincomb to new module sage.misc.repr |
07e0baa | sage.structure.parent_gens: Remove imports |
646042b | sage.structure.sequence: Make import of sage.misc.latex local to the latex method |
6517828 | sage.structure.factorization: Make import of sage.rings.integer.Integer local to methods |
54fabfc | sage.structure.factorization: Make import of sage.misc.misc_c.prod local to methods |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
3f5b6ea | Move sage.misc.misc.coeff_repr, repr_lincomb to new module sage.misc.repr |
97199dd | sage.structure.parent_gens: Remove imports |
bb4c6a8 | sage.structure.sequence: Make import of sage.misc.latex local to the latex method |
0820283 | sage.structure.factorization: Make import of sage.rings.integer.Integer local to methods |
7991b64 | sage.structure.factorization: Make import of sage.misc.misc_c.prod local to methods |
Branch pushed to git repo; I updated commit sha1. New commits:
08fedfa | src/sage/combinat/root_system/type_dual.py: Remove unused variable to fix pyflakes warning |
05efc11 | sage.misc.repr.coeff_repr: Add doctest, adapted from sage.misc.latex.coeff_repr |
538323b | src/sage/misc/call.py: Fix block syntax in docstring |
b5f63a5 | src/sage/misc/call.py: Returns should be Return |
2c77d17 | Merge branch 't/29892/move_sage_misc_misc_coeff_repr__repr_lincomb_to_new_module_sage_misc_repr' into t/29883/sage_structure__remove_some_module_level_imports |
f3afd30 | sage.categories.crystals: Make import of sage.misc.latex local to a method |
6433a56 | sage.categories: Make imports from sage.rings, .sets, .combinat, .plot, .matrix local to methods |
5c20de7 | Merge branch 't/16351/move_searchforest_code_to_sage_sets_recursively_enumerated_set_pyx' into t/29873/sage_categories_remove_module_level_imports |
27f2dab | src/sage/misc/call.py: Add coding directive |
a75ea75 | Merge branch 't/29873/sage_categories_remove_module_level_imports' into t/29883/sage_structure__remove_some_module_level_imports |
Merged in some tickets to take care of (unrelated) patchbot warnings
Green patchbot => positive review.
Reviewer: Travis Scrimshaw
this pyflakes warning looks like an actual bug to me (not from changes on this ticket)
src/sage/categories/finite_dimensional_algebras_with_basis.py:1449:29 undefined name 'x'
... that should be fixed on another ticket.
Changed branch from u/mkoeppe/sage_structure__remove_some_module_level_imports to a75ea75