sagemath/sage

Remove sagenb from "sage --notebook"

jhpalmieri opened this issue · 12 comments

jhpalmieri commented
  • Remove sagenb as a documented argument to the sage-notebook script, and remove the code to start the SageNB server.
  • Rewrite the error when sagenb is passed as an argument.
  • Change the default from SageNBExport to NotebookJupyter.

Component: scripts

Author: John Palmieri

Branch/Commit: f5853f9

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29885

jhpalmieri commented

Commit: 62bfb51

jhpalmieri commented

New commits:

62bfb51trac 29885: sage-notebook: remove sagenb as an option,
kcrisman commented
comment:3

I am okay with this. I would just add something like the last line here:

        print('See https://wiki.sagemath.org/Python3-Switch')
        print('Use sage --notebook=export to export sagenb notebooks to Jupyter')
kcrisman commented
comment:4

By the way, see #17590 and possibly elsewhere. But since 9.2 will (apparently) not support Py2, perhaps it's indeed better to simply remove sagenb than to keep it as an optional package that can't be launched from the command line.

sagetrac-git commented

Branch pushed to git repo; I updated commit sha1. New commits:

f5853f9trac 29885: add to the error message for "sage -n sagenb"
sagetrac-git commented

Changed commit from 62bfb51 to f5853f9

jhpalmieri commented
comment:6

Here is an expansion of the "sage -n sagenb" error message.

kcrisman commented
comment:7

Here is an expansion of the "sage -n sagenb" error message.

Thanks. The code looks good, someone who can test the branch should just confirm that this works, and that tests pass - I can imagine some stray doctest somewhere needing the class?

tscrim commented
comment:8

LGTM.

tscrim commented

Reviewer: Travis Scrimshaw