sagemath/sage

sage.structure, sage.misc: Replace import of sage.categories.all by more specific imports

Closed this issue · 10 comments

mkoeppe commented

sage.structure should only depend on basic categories such as sage.categories.morphism, sage.categories.pushout to support the parent/element framework and coercion, but not on more specialized ones such as sage.categories.modular_abelian_varieties.

This is for #29865 (sage-objects), which should pull in only a small part of sage.categories -- less than what sage.categories.basic imports.

CC: @tscrim @nthiery

Component: categories

Author: Matthias Koeppe

Branch/Commit: ce8fa70

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29916

mkoeppe commented

Description changed:

--- 
+++ 
@@ -1,3 +1,3 @@
 `sage.structure` should only depend on basic categories such as `sage.categories.morphism`, `sage.categories.pushout` to support the parent/element framework and coercion, but not on more specialized ones such as `sage.categories.modular_abelian_varieties`.
 
-This is for #29865.
+This is for #29865 (`sage-objects`), which should pull in only a small part of `sage.categories` -- less than what `sage.categories.basic` imports.
mkoeppe commented

Author: Matthias Koeppe

mkoeppe commented

New commits:

ce8fa70sage.structure, sage.misc: Replace import of sage.categories.all by more specific imports
mkoeppe commented

Commit: ce8fa70

mkoeppe commented
comment:5

Patchbot is green, needs review

tscrim commented
comment:6

LGTM.

tscrim commented

Reviewer: Travis Scrimshaw

mkoeppe commented
comment:7

Thanks!