Bug in KlyachkoBundle_class.random_deformation

[kliem]

The doctest in src/sage/schemes/toric/sheaf/klyachko.py does produce an error on some random seeds:

sage: set_random_seed(151058820726654196682836430928254760259)
sage: P1 = toric_varieties.P1()
sage: H = P1.divisor(0)
sage: V = P1.sheaves.line_bundle(H) + P1.sheaves.line_bundle(-H)
sage: V.cohomology(dim=True, weight=(0,))
(1, 0)
sage: Vtilde = V.random_deformation()
sage: Vtilde = V.random_deformation()
sage: Vtilde = V.random_deformation()
sage: Vtilde = V.random_deformation()
sage: Vtilde = V.random_deformation()
sage: Vtilde = V.random_deformation()
sage: Vtilde = V.random_deformation()
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-12-3095c5f6f78e> in <module>()
----> 1 Vtilde = V.random_deformation()

/home/jonathan/Applications/sage/local/lib/python3.7/site-packages/sage/schemes/toric/sheaf/klyachko.py in random_deformation(self, epsilon)
    953         """
    954         filt = self._filt.random_deformation(epsilon)
--> 955         return self.__class__(self.variety(), filt, check=True)

/home/jonathan/Applications/sage/local/lib/python3.7/site-packages/sage/schemes/toric/sheaf/klyachko.py in __init__(self, toric_variety, multi_filtration, check)
    176                              ' all rays of the fan.')
    177         if not multi_filtration.is_exhaustive():
--> 178             raise ValueError('multi-filtration must be exhaustive')
    179         if not multi_filtration.is_separating():
    180             raise ValueError('multi-filtration must be separating')

ValueError: multi-filtration must be exhaustive

Doctests are marked untested in #32543.

CC: @vbraun

Component: algebraic geometry

Keywords: CPR-Fano toric variety

Author: Andrey Belgorodski

Branch/Commit: 5f8fe4e

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/29956

[mkoeppe]

comment:3

Moving to 9.4, as 9.3 has been released.

[kliem]

Description changed:

--- 
+++ 
@@ -33,3 +33,5 @@
 
 ValueError: multi-filtration must be exhaustive
 ```
+
+Doctests are marked untested in #32543.

[sheerluck]

comment:6

diff --git a/src/sage/schemes/toric/sheaf/klyachko.py b/src/sage/schemes/toric/sheaf/klyachko.py
index 1ed3ac290b..32821e6d06 100644
--- a/src/sage/schemes/toric/sheaf/klyachko.py
+++ b/src/sage/schemes/toric/sheaf/klyachko.py
@@ -952,4 +952,6 @@ class KlyachkoBundle_class(SageObject):
            (1, 0)
         """
         filt = self._filt.random_deformation(epsilon)
+        while not filt.is_exhaustive():
+            filt = self._filt.random_deformation(epsilon)
         return self.__class__(self.variety(), filt, check=True)

[kliem]

Branch: public/29956

[kliem]

New commits:

0828599	mark unstable tests due to 29956
9fabf8a	Merge branch 'u/gh-kliem/mark_doctests_for_29956' of git://trac.sagemath.org/sage into public/29956
5f8fe4e	make sure that random multi-filtration is exhaustive

[kliem]

Reviewer: Jonathan Kliem

[kliem]

Commit: 5f8fe4e

[kliem]

Author: Andrey Belgorodski

[vbraun]

Changed branch from public/29956 to 5f8fe4e