Make geometry doctests ready for random seeds

Question

Make geometry doctests ready for random seeds

Closed this issue 5 years ago · 20 comments

This ticket makes

sage -t --long --random-seed=n src/sage/geometry/

pass for different values n than just 0 except for
src/sage/geometry/hyperbolic_space/hyperbolic_geodesic.py, which will be taken care of by #29936.

Depends on #29962
Depends on #29904

Component: doctest framework

Author: Jonathan Kliem

Branch/Commit: f7dc36b

Reviewer: Sébastien Labbé

Issue created by migration from https://trac.sagemath.org/ticket/29963

Answer 1 · 2020-06-24T20:15:27.000Z

Last 10 new commits:

`998b1b9`	`default random seed 0 for now`
`23ed583`	`fix doctest in hyperbolic_space/hyperbolic_point`
`5283dc4`	`use abs tol flag`
`7b244c0`	`modify doctests to the extend that they hold with fuzz`
`228f379`	`Merge branch 'public/29936' of git://trac.sagemath.org/sage into public/29962`
`5c7e562`	`fix double description of hypercube`
`e1bf211`	`remove set_random_seed`
`0e7a998`	`Merge branch 'public/29904' of git://trac.sagemath.org/sage into public/29962`
`b6a5dc7`	`fix random test in geometry/linear_expression`
`00c7575`	`dash instead of underscore for command line options`

Answer 2 · 2020-06-24T20:15:27.000Z

Branch: public/29963

Answer 3 · 2020-06-24T20:15:27.000Z

Commit: 00c7575

Answer 4 · 2020-07-09T07:43:58.000Z

Changed commit from 00c7575 to d67da8b

Answer 5 · 2020-07-09T07:43:58.000Z

New commits:

`6e57f0c`	`Merge branch 'public/29963' of git://trac.sagemath.org/sage into public/29963-reb`
`d67da8b`	`test whether a random element has the correct parent`

Answer 6 · 2020-07-09T07:43:58.000Z

Changed branch from public/29963 to public/29963-reb

Answer 7 · 2020-07-12T18:12:46.000Z

Changed branch from public/29963-reb to public/29963-reb2

Answer 8 · 2020-07-12T18:12:46.000Z

Changed commit from d67da8b to 0f59b95

Answer 9 · 2020-07-12T18:12:46.000Z

New commits:

`1d7b00e`	`dash instead of underscore for command line options`
`b31e2d5`	`Merge branch 'public/29962' of git://trac.sagemath.org/sage into public/29962-reb`
`2f30dd9`	`small fixes`
`b62f781`	`doctests do not start from a random seed by default yet`
`1d99129`	`fix merge conflict`
`0f59b95`	`fixed merge conflict`

Answer 10 · 2020-07-13T09:07:28.000Z

Changed commit from 0f59b95 to f7dc36b

Answer 11 · 2020-07-13T09:07:28.000Z

Changed branch from public/29963-reb2 to public/29963-reb3

Answer 12 · 2020-07-13T09:07:28.000Z

comment:4

This is not based on #29936 anymore.

Note that #29936 fixes a sign error in geometry/hyperbolic_space/hyperbolic_geodesic.py.

New commits:

`7e4c90b`	`fix doctest in hyperbolic_space/hyperbolic_point`
`f7dc36b`	`make random doctest fuzz ready`

Answer 13 · 2020-08-14T13:16:50.000Z

Changed dependencies from #29962, #29904, #29936 to #29962, #29904

Answer 14 · 2020-08-14T13:19:33.000Z

comment:6

If we want to make this independent of #29936, we need to change the objective.

It is just not based on #29936 to avoid constant merge conflicts. However, #29936 needs to be taken care of or we need to mark those things as known bugs.

Answer 15 · 2020-08-14T13:28:45.000Z

comment:7

If the issue with src/sage/geometry/hyperbolic_space/hyperbolic_geodesic.py is taken care of in another ticket, then the branch on this ticket can go in. It does not have to wait. I would suggest to downgrade the goal of this ticket to what the branch does.

Answer 16 · 2020-08-14T13:31:58.000Z

Description changed:

--- 
+++ 
@@ -3,4 +3,5 @@
 ```
 sage -t --long --random-seed=n src/sage/geometry/
 ```
-pass for different values `n` than just `0`.
+pass for different values `n` than just `0` except for 
+`src/sage/geometry/hyperbolic_space/hyperbolic_geodesic.py`, which will be taken care of by #29936.

Answer 17 · 2020-08-14T13:33:43.000Z

Reviewer: Sébastien Labbé

Answer 18 · 2020-08-14T13:33:43.000Z

comment:9

works for me

Answer 19 · 2020-08-14T13:34:54.000Z

comment:10

Thank you.

Answer 20 · 2020-08-16T22:33:10.000Z

Changed branch from public/29963-reb3 to f7dc36b