Make arith doctests ready for random seeds

Question

Make arith doctests ready for random seeds

Closed this issue 4 years ago · 17 comments

This ticket makes

sage -t --long --random-seed=n src/sage/arith/

pass for different values n than just 0.

Depends on #29962

Component: doctest framework

Author: Jonathan Kliem

Branch/Commit: 99b1ca1

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29970

Answer 1 · 2020-06-24T20:38:54.000Z

New commits:

`da1c6be`	`start from a "random" random seed for doctesting`
`b7b836d`	`make random seed reproducible`
`eedbe5e`	`document random_seed`
`998b1b9`	`default random seed 0 for now`
`1d7b00e`	`dash instead of underscore for command line options`
`08e9b18`	`make arith fuzz ready`

Answer 2 · 2020-06-24T20:38:54.000Z

Commit: 08e9b18

Answer 3 · 2020-06-24T20:38:54.000Z

Branch: public/29970

Answer 4 · 2020-06-24T20:38:54.000Z

Author: Jonathan Kliem

Answer 5 · 2020-07-12T18:15:40.000Z

comment:2

Merge conflict.

I also need to go through it again and check I respected the design decision in #29935.

Answer 6 · 2020-07-13T17:39:43.000Z

Changed branch from public/29970 to public/29970-reb

Answer 7 · 2020-07-13T17:39:43.000Z

New commits:

`b31e2d5`	`Merge branch 'public/29962' of git://trac.sagemath.org/sage into public/29962-reb`
`2f30dd9`	`small fixes`
`b62f781`	`doctests do not start from a random seed by default yet`
`1d99129`	`fix merge conflict`
`1924456`	`Merge branch 'public/29970' of git://trac.sagemath.org/sage into public/29970-reb`

Answer 8 · 2020-07-13T17:39:43.000Z

Changed commit from 08e9b18 to 1924456

Answer 9 · 2020-07-13T18:07:18.000Z

Changed commit from 1924456 to c8d01b9

Answer 10 · 2020-07-13T18:07:18.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`c8d01b9`	`respect desing decisions in src/sage/arith/misc.py`

Answer 11 · 2020-07-13T18:09:34.000Z

comment:5

There is probably a better way to fix the tests in src/sage/arith/multi_modular.pyx, but I don't understand what is going on and from the documentation it is not clear to me what MultiModularBasis_base(height) is supposed to return.

Answer 12 · 2021-03-15T22:07:04.000Z

comment:7

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

Answer 13 · 2021-06-01T10:53:56.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`99b1ca1`	`make arith ready for random doctesting`

Answer 14 · 2021-06-01T10:53:56.000Z

Changed commit from c8d01b9 to 99b1ca1

Answer 15 · 2021-06-03T17:25:22.000Z

Reviewer: Dima Pasechnik

Answer 16 · 2021-06-03T17:25:22.000Z

comment:10

lgtm

Answer 17 · 2021-06-19T20:58:44.000Z

Changed branch from public/29970-reb to 99b1ca1