Make rings doctests ready for random seeds

Question

Make rings doctests ready for random seeds

Closed this issue 4 years ago · 53 comments

This ticket makes

sage -t --long --random-seed=n src/sage/rings/

pass for different values n than just 0.

Depends on #32084
Depends on #32109
Depends on #32117
Depends on #32124

Component: doctest framework

Author: Jonathan Kliem

Branch/Commit: 3ddf396

Reviewer: Markus Wageringel

Issue created by migration from https://trac.sagemath.org/ticket/29979

Answer 1 · 2020-06-24T21:37:31.000Z

comment:1

I have a partial fix. After that at least the following need fixes:

sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/complex_double.pyx  # 3 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/complex_field.py  # 4 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/complex_interval_field.py  # 3 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/finite_rings/element_givaro.pyx  # 2 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/finite_rings/element_ntl_gf2e.pyx  # 2 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/finite_rings/finite_field_base.pyx  # 1 doctest failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/finite_rings/finite_field_givaro.py  # 2 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/finite_rings/finite_field_ntl_gf2e.py  # 2 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/finite_rings/integer_mod_ring.py  # 1 doctest failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/integer_ring.pyx  # 10 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/number_field/order.py  # 1 doctest failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/padics/generic_nodes.py  # 3 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/padics/padic_extension_generic.py  # 4 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/padics/tests.py  # 1 doctest failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/pari_ring.py  # 3 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/polynomial/cyclotomic.pyx  # 1 doctest failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/polynomial/multi_polynomial_element.py  # 1 doctest failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/polynomial/multi_polynomial_ideal.py  # 5 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/polynomial/multi_polynomial_ring_base.pyx  # 13 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/polynomial/pbori.pyx  # 27 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/polynomial/polynomial_element.pyx  # 4 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/polynomial/polynomial_quotient_ring.py  # 1 doctest failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/polynomial/polynomial_ring.py  # 7 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/polynomial/skew_polynomial_element.pyx  # 15 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/rational_field.py  # 6 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/real_double.pyx  # 2 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/real_mpfi.pyx  # 5 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/real_mpfr.pyx  # 12 doctests failed
sage -t --long --random-seed=151058820726654196682836430928254760259 src/sage/rings/ring.pyx  # 1 doctest failed

Answer 2 · 2020-06-24T21:38:53.000Z

Dependencies: #29962

Answer 3 · 2020-06-24T21:43:59.000Z

Branch: public/29979

Answer 4 · 2020-06-24T21:43:59.000Z

Commit: d076be5

Answer 5 · 2020-06-24T21:43:59.000Z

New commits:

`da1c6be`	`start from a "random" random seed for doctesting`
`b7b836d`	`make random seed reproducible`
`eedbe5e`	`document random_seed`
`998b1b9`	`default random seed 0 for now`
`1d7b00e`	`dash instead of underscore for command line options`
`d076be5`	`partially make rings fuzz ready`

Answer 6 · 2021-03-15T22:07:04.000Z

comment:5

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

Answer 7 · 2021-04-28T19:34:22.000Z

Changed dependencies from #29962 to #29962, #31752

Answer 8 · 2021-06-29T21:09:41.000Z

Changed commit from d076be5 to 2a3eebb

Answer 9 · 2021-06-29T21:09:41.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`a03aebb`	`make some files of rings fuzz ready`
`e92d0a6`	`some changes to make rings fuzz ready`
`8d93480`	`make rings ready for fuzzed doctests`
`f008269`	add ticket numbers to `not tested`
`540413e`	`fix various remaining doctests in rings`
`2a3eebb`	`a few more doctests`

Answer 10 · 2021-06-29T21:09:59.000Z

Author: Jonathan Kliem

Answer 11 · 2021-06-29T21:12:34.000Z

comment:9

If a reviewer feels like we should split this into several tickets, then this is also fine with me (e.g. start with some submodules).

Answer 12 · 2021-06-29T21:29:37.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`5c027a7`	`get a random nonzero element`

Answer 13 · 2021-06-29T21:29:37.000Z

Changed commit from 2a3eebb to 5c027a7

Answer 14 · 2021-06-30T12:00:19.000Z

Changed dependencies from #29962, #31752 to none

Answer 15 · 2021-07-03T05:54:56.000Z

Work Issues: remove marked bug from #32084

Answer 16 · 2021-07-03T06:08:00.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`6d56c0a`	`remove bug tag as bug has been resolved in 32084`

Answer 17 · 2021-07-03T06:08:00.000Z

Changed commit from 5c027a7 to 6d56c0a

Answer 18 · 2021-07-03T06:08:26.000Z

Changed work issues from remove marked bug from #32084 to none

Answer 19 · 2021-07-03T07:00:36.000Z

Changed commit from 6d56c0a to 74c2425

Answer 20 · 2021-07-03T07:00:36.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`74c2425`	`two more failing tests for rings`

Answer 21 · 2021-07-03T09:04:25.000Z

comment:16

There are a few more tests that fail (some of these might be duplicates):

sage -t --long --warn-long 62.5 --random-seed=3000 src/sage/rings/tate_algebra_element.pyx  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3000 src/sage/rings/tests.py  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3002 src/sage/rings/finite_rings/integer_mod.pyx  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3002 src/sage/rings/padics/padic_generic_element.pyx  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3003 src/sage/rings/finite_rings/integer_mod.pyx  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3004 src/sage/rings/finite_rings/integer_mod.pyx  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3007 src/sage/rings/polynomial/ore_function_field.py  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3009 src/sage/rings/polynomial/ore_polynomial_element.pyx  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3009 src/sage/rings/tests.py  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3011 src/sage/rings/polynomial/ore_function_element.py  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3012 src/sage/rings/finite_rings/integer_mod.pyx  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3013 src/sage/rings/continued_fraction.py  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3014 src/sage/rings/finite_rings/integer_mod.pyx  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3017 src/sage/rings/invariants/invariant_theory.py  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3019 src/sage/rings/finite_rings/integer_mod.pyx  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3023 src/sage/rings/finite_rings/integer_mod.pyx  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3028 src/sage/rings/padics/padic_generic_element.pyx  # 2 doctests failed
sage -t --long --warn-long 62.5 --random-seed=3030 src/sage/rings/tests.py  # 7 doctests failed
sage -t --long --warn-long 62.5 --random-seed=3031 src/sage/rings/finite_rings/integer_mod.pyx  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3035 src/sage/rings/finite_rings/integer_mod.pyx  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3037 src/sage/rings/finite_rings/integer_mod.pyx  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3040 src/sage/rings/finite_rings/integer_mod.pyx  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3042 src/sage/rings/padics/padic_generic_element.pyx  # 2 doctests failed
sage -t --long --warn-long 62.5 --random-seed=3043 src/sage/rings/finite_rings/integer_mod.pyx  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3043 src/sage/rings/invariants/invariant_theory.py  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3043 src/sage/rings/polynomial/ore_function_element.py  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3049 src/sage/rings/tate_algebra_element.pyx  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3050 src/sage/rings/finite_rings/integer_mod.pyx  # 1 doctest failed
sage -t --long --warn-long 62.5 --random-seed=3050 src/sage/rings/padics/padic_generic_element.pyx  # 1 doctest failed

Answer 22 · 2021-07-03T09:47:02.000Z

comment:17

Thanks for catching those. It's really hard to catch all those one in a thousand failures in all of sage...

Answer 23 · 2021-07-03T12:46:52.000Z

Dependencies: #32084

Answer 24 · 2021-07-03T12:49:55.000Z

Changed dependencies from #32084 to #32084, #32109

Answer 25 · 2021-07-03T18:38:37.000Z

comment:20

And some of the errors are really something.

In src/sage/rings/tests.py we are trying to construct a relative number field by only checking that the polynomial is irreducible over ZZ...

Answer 26 · 2021-07-03T20:52:22.000Z

Changed dependencies from #32084, #32109 to #32084, #32109, #32117

Answer 27 · 2021-07-03T21:18:23.000Z

Last 10 new commits:

`0994f0f`	`trac 32084 fix nth root`
`226fe84`	`trac 32084 fix nth root`
`e280083`	`Merge branch 'public/32084r2' of git://trac.sagemath.org/sage into public/29979-reb`
`9e53965`	`fix 0/0 in ore function field`
`192b564`	`add ticked number to test`
`b20059c`	`Merge branch 'public/32109' of git://trac.sagemath.org/sage into public/29979-reb`
`ce98d48`	`two more doctests`
`34a233d`	`pull in 32117`
`cfe869b`	`modulo n better be for n > 0`
`3752b9c`	`some more remaining tests`

Answer 28 · 2021-07-03T21:18:23.000Z

Changed commit from 74c2425 to 3752b9c

Answer 29 · 2021-07-03T21:18:23.000Z

Changed branch from public/29979 to public/29979-reb

Answer 30 · 2021-07-04T12:39:36.000Z

Changed commit from 3752b9c to 36c7c58

Answer 31 · 2021-07-04T12:39:36.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`e6a697a`	`truely ignore ignored bounds for ZZ.random_element`
`36c7c58`	`pull 32124`

Answer 32 · 2021-07-04T12:40:06.000Z

Changed dependencies from #32084, #32109, #32117 to #32084, #32109, #32117, #32124

Answer 33 · 2021-07-04T15:33:21.000Z

Changed commit from 36c7c58 to be3e05f

Answer 34 · 2021-07-04T15:33:21.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`be3e05f`	`29979: a few more fixes`

Answer 35 · 2021-07-04T15:39:59.000Z

comment:26

Replying to @kliem:

It's really hard to catch all those one in a thousand failures in all of sage...

I agree and I appreciate all the work you put into this a lot. In the last commit, I have just added a few small fixes for some other test failures I found.

Answer 36 · 2021-07-05T09:32:07.000Z

comment:27

The continue_fraction_gosper.py doctest sometimes fails for negative period as well. I'm not sure if this is a bug or just the doctest being incorrect::

sage: def foo(a, b, c, d): 
....:      from sage.rings.continued_fraction_gosper import gosper_iterator 
....:      x = continued_fraction(([1,2],[3,4])); i = iter(gosper_iterator(a,b,c,d,x)) 
....:      l = list(i) 
....:      preperiod_length = i.output_preperiod_length 
....:      preperiod = l[:preperiod_length] 
....:      period = [abs(w) for w in l[preperiod_length:]] 
....:      c == d == 0 or continued_fraction((preperiod, period), x.value()) == continued_fraction((a*x.value()+b)/(c*x.value()+d)) 
sage: for i in range(-10, 11): 
....:     for j in range(-10, 11): 
....:         try: 
....:             foo(0,0,i,j) 
....:         except: 
....:             print("foo(0, 0, %s, %s)" % (i, j)) 
....:              
....:                                                                                                                                 
foo(0, 0, -9, 10)
foo(0, 0, -8, 9)
foo(0, 0, -8, 10)
foo(0, 0, -7, 8)
foo(0, 0, -7, 9)
foo(0, 0, -7, 10)
foo(0, 0, -6, 7)
foo(0, 0, -6, 8)
foo(0, 0, -6, 9)
foo(0, 0, -5, 6)
foo(0, 0, -5, 7)
foo(0, 0, -4, 5)
foo(0, 0, -4, 6)
foo(0, 0, -3, 4)
foo(0, 0, -2, 3)
foo(0, 0, 2, -3)
foo(0, 0, 3, -4)
foo(0, 0, 4, -6)
foo(0, 0, 4, -5)
foo(0, 0, 5, -7)
foo(0, 0, 5, -6)
foo(0, 0, 6, -9)
foo(0, 0, 6, -8)
foo(0, 0, 6, -7)
foo(0, 0, 7, -10)
foo(0, 0, 7, -9)
foo(0, 0, 7, -8)
foo(0, 0, 8, -10)
foo(0, 0, 8, -9)
foo(0, 0, 9, -10)

Answer 37 · 2021-07-05T18:29:35.000Z

Changed commit from be3e05f to 5f0f5dc

Answer 38 · 2021-07-05T18:29:35.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`5f0f5dc`	`29979: mark failing tests as not tested`

Answer 39 · 2021-07-05T18:31:11.000Z

comment:29

Replying to @kliem:

The continue_fraction_gosper.py doctest sometimes fails for negative period as well. I'm not sure if this is a bug or just the doctest being incorrect::

I am not sure either. I have opened #32127 for this problem and have now marked this test as well as the other tests for which I opened tickets yesterday as not tested.

Answer 40 · 2021-07-05T20:15:10.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`bc1e14a`	`29979: minor tweaks of doctests`

Answer 41 · 2021-07-05T20:15:10.000Z

Changed commit from 5f0f5dc to bc1e14a

Answer 42 · 2021-07-05T20:24:48.000Z

Reviewer: Markus Wageringel

Answer 43 · 2021-07-05T20:24:48.000Z

comment:31

I have now reviewed your code and made a few small adjustments. The line I removed in multi_polynomial_ring_base seems redundant since R is the base ring of S, but I think the test might have failed if f happened to be zero.

Do you agree with my changes? It is inevitable that there are still sporadic failures, but to me the current branch seems robust enough for now. Nice work.

Answer 44 · 2021-07-06T07:16:23.000Z

comment:32

Thanks for the improvements.

Answer 45 · 2021-07-06T19:18:43.000Z

comment:33

So we can set this ticket to positive then.

Answer 46 · 2021-07-06T19:27:01.000Z

Changed commit from bc1e14a to 5330692

Answer 47 · 2021-07-06T19:27:01.000Z

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

`5330692`	`minor style error`

Answer 48 · 2021-07-06T19:27:19.000Z

comment:36

Thank you.

Answer 49 · 2021-07-23T22:09:32.000Z

comment:37

Merge conflict

Answer 50 · 2021-08-09T11:35:27.000Z

comment:38

Rebased.

New commits:

`3ddf396`	`merge 29979 into develop`

Answer 51 · 2021-08-09T11:35:27.000Z

Changed branch from public/29979-reb to public/29979-reb2

Answer 52 · 2021-08-09T11:35:27.000Z

Changed commit from 5330692 to 3ddf396

Answer 53 · 2021-08-29T09:37:51.000Z

Changed branch from public/29979-reb2 to 3ddf396