sagemath/sage

Make plot doctests ready for random seeds

Closed this issue · 14 comments

kliem commented

This ticket makes

sage -t --long --random-seed=n src/sage/plot/

pass for different values n than just 0.

This was already taken care of by #30176.

Component: doctest framework

Reviewer: Dave Morris

Issue created by migration from https://trac.sagemath.org/ticket/29986

kliem commented

Author: Jonathan Kliem

kliem commented

Commit: 37a9e1c

kliem commented

Branch: public/29986

kliem commented

New commits:

da1c6bestart from a "random" random seed for doctesting
b7b836dmake random seed reproducible
eedbe5edocument random_seed
998b1b9default random seed 0 for now
1d7b00edash instead of underscore for command line options
37a9e1cmake plot fuzz ready
kliem commented
comment:2

Merge conflict.

I also need to go through it again and check I respected the design decision in #29935.

kliem commented
comment:4

It appears that without a solution to #29954, this task might be infeasible (unless you want to mark every single doctest counting the graphic primitives as known bug).

Reviewer: Dave Morris

comment:5

This can be closed as a duplicate of #30176, because commit 73af14a of that ticket adjusted the tolerance of these two doctests. I tried a dozen different seeds and didn't get any doctest failures in the plot directory.

kliem commented

Changed dependencies from #29962 to none

kliem commented

Changed author from Jonathan Kliem to none

kliem commented
comment:6

Agreed.

kliem commented

Changed commit from 37a9e1c to none

kliem commented

Description changed:

--- 
+++ 
@@ -5,3 +5,4 @@
 ```
 pass for different values `n` than just `0`.
 
+This was already taken care of by #30176.
kliem commented

Changed branch from public/29986 to none