sagemath/sage

Add ipywidgets as a dependency to packages using the sage doctester

mkoeppe opened this issue · 16 comments

Follow-up from #29426:

Currently giacpy_sage tests fail (https://github.com/mkoeppe/sage/runs/959684347) because its sage-check needs the sage doctester

Depends on #29766

CC: @slel @kiwifb @frederichan-IMJPRG

Component: packages: optional

Issue created by migration from https://trac.sagemath.org/ticket/30324

Dependencies: #29766

Commit: 4ddcc6f

Last 10 new commits:

3558737build/pkgs/numpy/patches/16871.patch: New
1bf6249Update numpy to 1.19.1, add patches
061e975Merge branch 'u/mkoeppe/upgrade_cython_to_0_29_20' of git://trac.sagemath.org/sage into t/29766/packages/networkx24
fc7592cMerge branch 't/29929/tox_ini__add_a_macos_environment_without_homebrew__conda' into t/29766/packages/networkx24
7fe5985right place for warnings.filterwarnings() for networkx & scipy
5fa0bbabuild/pkgs/scipy: Update to 1.5.2
3890e1abuild/make/Makefile.in: Improve handling of SAGE_CHECK_PACKAGES
5d4b013build/make/Makefile.in: Handle the case in which SAGE_CHECK_PACKAGES is set using a command argument
b65f563Merge branch 't/29766/packages/networkx24' into t/30324/add_ipywidgets_as_a_dependency_to_packages_using_the_sage_doctester
4ddcc6fbuild/pkgs/giacpy_sage/dependencies: Add ipywidgets if SAGE_CHECK!=no

Changed commit from 4ddcc6f to 813bbf7

Branch pushed to git repo; I updated commit sha1. New commits:

813bbf7build/pkgs/giacpy_sage/dependencies: Fixup: Need SAGERUNTIME for installing

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/201918837 to github.com/mkoeppe/sage/actions/runs/202669190

comment:8

This conflicts with #29171, of course

comment:9

debian-stretch-maximal (https://github.com/mkoeppe/sage/runs/967227907)

Running the test suite for giacpy_sage-0.6.8...
...
    from .widgets_sagenb import (input_box, text_control, slider,
  File "/sage/local/lib/python3.7/site-packages/sage/repl/ipython_kernel/widgets_sagenb.py", line 30, in <module>
    from ipywidgets.widgets import (IntSlider, IntRangeSlider, FloatSlider,
ModuleNotFoundError: No module named 'ipywidgets'
comment:10

... and I thought I had fixed the SAGE_CHECK_... business in #29766...

Changed author from Matthias Koeppe to none

Changed reviewer from github.com/mkoeppe/sage/actions/runs/202669190 to none

comment:12

#29171 is removing the package, so this ticket can be closed

slel commented

Changed commit from 813bbf7 to none