sagemath/sage

Clean up sage_setup.library_order

Closed this issue · 13 comments

mkoeppe commented

Follow-up from #29702, #29706:

We remove code that duplicated the function of sage.env.cython_aliases

CC: @jhpalmieri @kiwifb @dimpase

Component: build

Author: Matthias Koeppe

Branch/Commit: 49cd771

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/30579

mkoeppe commented

New commits:

eb8db08src/sage_setup/library_order.py: Get library lists from sage.env.cython_aliases
mkoeppe commented

Commit: eb8db08

sagetrac-git commented

Branch pushed to git repo; I updated commit sha1. New commits:

43966d6Merge tag '9.3.beta0' into t/30579/clean_up_sage_setup_library_order
3fca461src/sage_setup/library_order.py: Remove unused import
sagetrac-git commented

Changed commit from eb8db08 to 3fca461

mkoeppe commented
comment:6

Needs review

dimpase commented
comment:7

ok, this works

dimpase commented

Reviewer: Dima Pasechnik

mkoeppe commented
comment:8

Thanks!

vbraun commented
comment:9

Merge conflict

sagetrac-git commented

Changed commit from 3fca461 to 49cd771

sagetrac-git commented

Branch pushed to git repo; I updated commit sha1. New commits:

49cd771Merge tag '9.3.beta2' into t/30579/clean_up_sage_setup_library_order