sage --package download is broken
seblabbe opened this issue · 12 comments
seblabbe commented
$ sage --package download cbc
Traceback (most recent call last):
File "/home/slabbe/GitBox/sage/build/bin/sage-package", line 42, in <module>
run()
File "/home/slabbe/GitBox/sage/build/bin/../sage_bootstrap/cmdline.py", line 318, in run
app.download_cls(args.package_name, args.allow_upstream)
TypeError: download_cls() takes exactly 2 arguments (3 given)
Component: distribution
Author: Sébastien Labbé
Branch: e463513
Reviewer: Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/30648
mkoeppe commented
comment:1
Looks like I broke this when adding the upstream_url feature. I'll looking into fixing it
seblabbe commented
comment:2
doing this change:
- app.download_cls(args.package_name, args.allow_upstream)
+ app.download(args.package_name, args.allow_upstream)fixed it on my side
seblabbe commented
comment:3
I don't know if this is the correct fix.
I don't know if there are similar error in the file.
I just know that this change allowed me to download the tarball I was looking for.
New commits:
e463513 | 30648: download_cls -> download |
seblabbe commented
Author: Sébastien Labbé
seblabbe commented
Branch: u/slabbe/30648
seblabbe commented
comment:5
a gentle ping
mkoeppe commented
Reviewer: Matthias Koeppe
seblabbe commented
comment:7
thanks for the review
vbraun commented
Changed branch from u/slabbe/30648 to e463513