Extract cython config to new module
tobiasdiez opened this issue · 13 comments
As suggested in #30371, the cython config is extracted to a new module to make it easier to reuse it in the editable install.
CC: @mkoeppe
Component: build
Author: Tobias Diez
Branch/Commit: cc96c6d
Reviewer: Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/30709
Author: Tobias Diez
Reviewer: Matthias Koeppe
Thanks!
See patchbot:
[dochtml] [arithgrou] The inventory files are in local/share/doc/sage/inventory/en/reference/arithgroup.
[dochtml] Build finished. The built documents can be found in /home/sagemath/sage-9.1/local/share/doc/sage/inventory/en/reference/arithgroup
[dochtml] [graphs ] building [inventory]: targets for 73 source files that are out of date
[dochtml] [graphs ] updating environment: [new config] 73 added, 0 changed, 0 removed
[dochtml] [combinat ] /home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage/combinat/crystals/mv_polytopes.py:docstring of sage.combinat.crystals.mv_polytopes.MVPolytope.plot:22: WARNING: Exception occurred in plotting mv_polytopes-1
[dochtml] [combinat ] from /home/sagemath/sage-9.1/src/doc/en/reference/combinat/sage/combinat/crystals/mv_polytopes.rst:
[dochtml] [combinat ] Traceback (most recent call last):
[dochtml] [combinat ] File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/matplotlib/sphinxext/plot_directive.py", line 472, in run_code
[dochtml] [combinat ] exec(code, ns)
[dochtml] [combinat ] File "<string>", line 4, in <module>
[dochtml] [combinat ] File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage/combinat/root_system/root_lattice_realizations.py", line 2053, in plot
[dochtml] [combinat ] G += self.plot_roots(roots, plot_options=plot_options)
[dochtml] [combinat ] File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage/combinat/root_system/root_lattice_realizations.py", line 2299, in plot_roots
[dochtml] [combinat ] roots = Family(roots, self)
[dochtml] [combinat ] File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage/sets/family.py", line 406, in Family
[dochtml] [combinat ] return LazyFamily(indices, function, name)
[dochtml] [combinat ] File "/home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage/sets/family.py", line 908, in __init__
[dochtml] [combinat ] self.set = copy(set)
[dochtml] [combinat ] File "/usr/lib/python3.7/copy.py", line 106, in copy
[dochtml] [combinat ] return _reconstruct(x, None, *rv)
[dochtml] [combinat ] File "/usr/lib/python3.7/copy.py", line 274, in _reconstruct
[dochtml] [combinat ] y = func(*args)
[dochtml] [combinat ] File "stringsource", line 7, in sage.structure.sage_object.__pyx_unpickle_SageObject (build/cythonized/sage/structure/sage_object.c:11738)
[dochtml] [combinat ] TypeError: sage.structure.sage_object.SageObject.__new__(FiniteFamily_with_category) is not safe, use FiniteFamily_with_category.__new__()
[dochtml] [combinat ] /home/sagemath/sage-9.1/local/lib/python3.7/site-packages/sage/combinat/crystals/mv_polytopes.py:docstring of sage.combinat.crystals.mv_polytopes.MVPolytopes:101: WARNING: Exception occurred in plotting mv_polytopes-2
[dochtml] [combinat ] from /home/sagemath/sage-9.1/src/doc/en/reference/combinat/sage/combinat/crystals/mv_polytopes.rst:
Looks like auto_pickle=False, was lost
Oh, that was indeed an overlook on my side. Thanks for fixing it. The patchbot complains about malformed blocks, which I don't really understand.
Replying to @tobiasdiez:
The patchbot complains about malformed blocks, which I don't really understand.
"Returns" should be "Return" according to style guide.
Branch pushed to git repo; I updated commit sha1. New commits:
cc96c6d | Returns -> Return |
Thanks!
Changed branch from public/build/cythonConfig to cc96c6d