Meta-ticket: Set environment for subprocesses invoked by Sage

Question

Meta-ticket: Set environment for subprocesses invoked by Sage

Opened this issue 5 years ago · 17 comments

Instead of relying on running in an environment set up by sage-env, we should set up specific environment variables whenever we invoke executables. This will be configurable through sage_conf.

This is so that Sage is fully functional even when not being run from within sage-env. This continues what was done in #29038/#30563 for Maxima.

As this ticket removes some hard-coded paths depending on SAGE_LOCAL from sagelib, it will reduce the need for patching for downstream packaging.

A possible implementation strategy goes through sage.features.Executable.

This is part of:

#21707 Meta-ticket: Split sage-env into 5 to clean up sage configuration

Taken care of in separate tickets:

#32036 sage.env: Remove fallback of SAGE_LOCAL to SAGE_VENV, remove direct uses of SAGE_LOCAL from the Sage library
#31296 sage.features.Executable: Prepend $SAGE_VENV/bin:$SAGE_LOCAL/bin to PATH, remove dependency on distutils
#31275 qepcad
#29024/#33440 singular
#30887 4ti2
#33465 sage.graphs: Use Executable.absolute_filename()
#33466 lrs
#32645 cddlib
#33467 palp
#33468 gfan
#33405 Eliminate direct use of os.getenv in sage.interfaces
#29644 gap
environment for C compiler use at runtime (includes ARCHFLAGS - see #31227)
#31041 environment for sage.misc.cython

CC: @kiwifb @tobiasdiez @dimpase @antonio-rojas @orlitzky @seblabbe

Component: refactoring

Keywords: sd111

Issue created by migration from https://trac.sagemath.org/ticket/30818

Answer 1 · 2020-10-23T21:17:49.000Z

Description changed:

--- 
+++ 
@@ -4,3 +4,7 @@
 
 As this ticket removes some hard-coded paths depending on `SAGE_LOCAL` from sagelib, it will reduce the need for patching for downstream packaging.
 
+This is part of:
+- #21707 Meta-ticket: Split `sage-env` into 5 to clean up sage configuration
+
+

Answer 2 · 2020-10-23T21:45:35.000Z

Description changed:

--- 
+++ 
@@ -7,4 +7,7 @@
 This is part of:
 - #21707 Meta-ticket: Split `sage-env` into 5 to clean up sage configuration
 
+Taken care of in separate tickets:
+- #21783 QEPCAD: Location of `default.qepcadrc` and other files, get rid of qepcad bits in `src/bin/sage-location`, add `spkg-configure`
+- environment for C compiler use at runtime

Answer 3 · 2020-10-23T21:48:21.000Z

Description changed:

--- 
+++ 
@@ -8,6 +8,7 @@
 - #21707 Meta-ticket: Split `sage-env` into 5 to clean up sage configuration
 
 Taken care of in separate tickets:
-- #21783 QEPCAD: Location of `default.qepcadrc` and other files, get rid of qepcad bits in `src/bin/sage-location`, add `spkg-configure`
+- #21783 qepcad
+- #29024 singular
 - environment for C compiler use at runtime

Answer 4 · 2020-10-23T21:50:27.000Z

Description changed:

--- 
+++ 
@@ -10,5 +10,6 @@
 Taken care of in separate tickets:
 - #21783 qepcad
 - #29024 singular
+- #29644 gap
 - environment for C compiler use at runtime

Answer 5 · 2020-11-11T01:28:27.000Z

Description changed:

--- 
+++ 
@@ -11,5 +11,6 @@
 - #21783 qepcad
 - #29024 singular
 - #29644 gap
+- #30887 4ti2
 - environment for C compiler use at runtime

Answer 6 · 2020-12-06T18:17:38.000Z

comment:6

Hoping we can make progress on this ticket this week - https://wiki.sagemath.org/days111

Answer 7 · 2020-12-06T18:17:38.000Z

Changed keywords from none to sd111

Answer 8 · 2020-12-10T21:17:22.000Z

Description changed:

--- 
+++ 
@@ -13,4 +13,4 @@
 - #29644 gap
 - #30887 4ti2
 - environment for C compiler use at runtime
-
+- environment for `sage.misc.cython`

Answer 9 · 2020-12-11T19:14:38.000Z

Description changed:

--- 
+++ 
@@ -13,4 +13,4 @@
 - #29644 gap
 - #30887 4ti2
 - environment for C compiler use at runtime
-- environment for `sage.misc.cython`
+- #31041 environment for `sage.misc.cython`

Answer 10 · 2021-01-26T18:43:15.000Z

Description changed:

--- 
+++ 
@@ -8,7 +8,7 @@
 - #21707 Meta-ticket: Split `sage-env` into 5 to clean up sage configuration
 
 Taken care of in separate tickets:
-- #21783 qepcad
+- #31275 qepcad
 - #29024 singular
 - #29644 gap
 - #30887 4ti2

Answer 11 · 2021-01-26T18:47:47.000Z

Description changed:

--- 
+++ 
@@ -3,6 +3,8 @@
 This is so that Sage is fully functional even when not being run from within `sage-env`.  This continues what was done in #29038/#30563 for Maxima.
 
 As this ticket removes some hard-coded paths depending on `SAGE_LOCAL` from sagelib, it will reduce the need for patching for downstream packaging.
+
+A possible implementation strategy goes through `sage.features.Executable`.
 
 This is part of:
 - #21707 Meta-ticket: Split `sage-env` into 5 to clean up sage configuration

Answer 12 · 2021-01-26T20:38:26.000Z

Description changed:

--- 
+++ 
@@ -10,6 +10,7 @@
 - #21707 Meta-ticket: Split `sage-env` into 5 to clean up sage configuration
 
 Taken care of in separate tickets:
+- #31296 `sage.features.Executable`: Prepend `$SAGE_VENV/bin:$SAGE_LOCAL/bin` to `PATH`, remove dependency on `distutils`
 - #31275 qepcad
 - #29024 singular
 - #29644 gap

Answer 13 · 2021-01-31T00:12:59.000Z

Description changed:

--- 
+++ 
@@ -15,5 +15,5 @@
 - #29024 singular
 - #29644 gap
 - #30887 4ti2
-- environment for C compiler use at runtime
+- environment for C compiler use at runtime (includes `ARCHFLAGS` - see #31227)
 - #31041 environment for `sage.misc.cython`

Answer 14 · 2021-03-24T02:04:25.000Z

comment:13

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

Answer 15 · 2021-06-23T23:32:33.000Z

Description changed:

--- 
+++ 
@@ -10,6 +10,7 @@
 - #21707 Meta-ticket: Split `sage-env` into 5 to clean up sage configuration
 
 Taken care of in separate tickets:
+- #32036 `sage.env`: Remove fallback of `SAGE_LOCAL` to `SAGE_VENV`, remove direct uses of `SAGE_LOCAL` from the Sage library
 - #31296 `sage.features.Executable`: Prepend `$SAGE_VENV/bin:$SAGE_LOCAL/bin` to `PATH`, remove dependency on `distutils`
 - #31275 qepcad
 - #29024 singular

Answer 16 · 2022-03-13T04:24:06.000Z

Description changed:

--- 
+++ 
@@ -13,8 +13,14 @@
 - #32036 `sage.env`: Remove fallback of `SAGE_LOCAL` to `SAGE_VENV`, remove direct uses of `SAGE_LOCAL` from the Sage library
 - #31296 `sage.features.Executable`: Prepend `$SAGE_VENV/bin:$SAGE_LOCAL/bin` to `PATH`, remove dependency on `distutils`
 - #31275 qepcad
-- #29024 singular
+- #29024/#33440 singular
+- #30887 4ti2
+- #33465 `sage.graphs`: Use `Executable.absolute_filename()`
+- #33466 `lrs`
+- #32645 `cddlib`
+- #33467 `palp`
+- #33405 Eliminate direct use of `os.getenv` in `sage.interfaces`
 - #29644 gap
-- #30887 4ti2
 - environment for C compiler use at runtime (includes `ARCHFLAGS` - see #31227)
 - #31041 environment for `sage.misc.cython`
+

Answer 17 · 2022-03-25T19:26:37.000Z

Description changed:

--- 
+++ 
@@ -19,6 +19,7 @@
 - #33466 `lrs`
 - #32645 `cddlib`
 - #33467 `palp`
+- #33468 `gfan`
 - #33405 Eliminate direct use of `os.getenv` in `sage.interfaces`
 - #29644 gap
 - environment for C compiler use at runtime (includes `ARCHFLAGS` - see #31227)