FPLLL 5.4.0 on macOS with homebrew
Closed this issue · 11 comments
After #31025, homebrew fplll is not detected which leads to a compilation error of fpylll.
See discussion on https://groups.google.com/g/sage-release/c/1rJF7CzEksY and
#31025 comment:41
This patch fixes the issue.
Component: packages: standard
Author: David Coudert, François Bissey
Branch/Commit: 36c157c
Reviewer: Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/31127
Using '>=' is definitely not the right fix -- see the comment right above the change in the file and discussion in #31025.
According to https://autotools.io/pkgconfig/pkg_check_modules.html you shouldn't use == but =. And it is indeed correct here
fbissey@equinoxe ~ $ pkg-config --exists --print-errors "libzip = 1.7"
Requested 'libzip = 1.7' but version of libzip is 1.7.3
fbissey@equinoxe ~ $ pkg-config --exists --print-errors "libzip == 1.7"
Unknown version comparison operator '==' after package name 'libzip' in file '(command line arguments)'
Branch pushed to git repo; I updated commit sha1. New commits:
36c157c | trac #31127: correct version test |
For me fplll = 5.4.0 works, but not fplll = 5.4.
Reviewer: Matthias Koeppe
Changed author from David Coudert to David Coudert, François Bissey
Changed branch from public/packages/31127_fplll_and_homebrew to 36c157c